WIP Visualization using Foxglove #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a frame data to foxglove-studio
…ed in foxglove-studio)
…s (both as rgb frame and point cloud), also cleaned up some code
…me code to be removed
…ll some pygame code in other files
…nt_cloud.py, and segmented_frame.py
…Publisher.py to ros_lidar_publisher.py and adjusted import statement in visualizer operator
pschafhalter
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Nice work!
In addition to the comments, a few more things need to be done:
- Fix merge conflicts. A quick way to do this is to add this repo as the upstream repository
git fetch upstream masterand thengit rebase upstream/master - Push changes to
operator_creator.py. I think you have some locally that haven't been pushed. - Fix the Dockerfile.
- Fix the code formatting. An easy way to do this is to pip install yapf and run
yapf -i <myfile.py>to automatically format. - Automatically start and shutdown ROS/Foxglove in the visualizer operator.
Also, I was having some issues running Foxglove on a remote machine. Running foxglove-studio --no-sandbox as you suggested helped, but the content of the window doesn't render. It could be an issue with my internet speeds/X-server being slow. We need to look into this before merging this PR.
|
Rosbridge provides a potential work-around for the rendering issue I ran into:
|
Co-authored-by: Peter Schafhalter <[email protected]>
Co-authored-by: Peter Schafhalter <[email protected]>
Co-authored-by: Peter Schafhalter <[email protected]>
…and methods, and added comments to visualizer operator
…a frame data to foxglove-studio
…ed in foxglove-studio)
…s (both as rgb frame and point cloud), also cleaned up some code
…me code to be removed
…ll some pygame code in other files
…nt_cloud.py, and segmented_frame.py
…Publisher.py to ros_lidar_publisher.py and adjusted import statement in visualizer operator
…and methods, and added comments to visualizer operator
Co-authored-by: Peter Schafhalter <[email protected]>
Co-authored-by: Peter Schafhalter <[email protected]>
Co-authored-by: Peter Schafhalter <[email protected]>
merge required to incorporate suggested changes on the WIP foxglove visualization pull request
ICGog
reviewed
Jul 27, 2021
|
Just checking, if I rebased onto master earlier, would there be any way to avoid resolving the same merge conflicts again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ROS publishers to send data to Foxglove for visualization. Removed pygame dependencies in the visualizer operator and operator creator. Additionally, removed the run_visualizer_control_loop() method in utils.py (and its calls) and the visualize() method in frame classes (camera_frame.py, point_cloud.py, etc.).
Dockerfile needs to be updated to install foxglove studio and ROS correctly.
Should the control_display_stream be kept or deleted?
Example screenshot (visualizing detected obstacles and depth camera (both depth frame and point cloud):
