Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary changes in Brugge reference simulation #46

Open
edubarrosTNO opened this issue Apr 14, 2021 · 1 comment
Open

Necessary changes in Brugge reference simulation #46

edubarrosTNO opened this issue Apr 14, 2021 · 1 comment
Assignees

Comments

@edubarrosTNO
Copy link
Contributor

  1. In order to be able to better analyze FlowNet results in the Brugge example, the reference simulation should output some additional summary vectors. A few ones that I noticed to be missing are: FOPT, FWPT, FWIT, FOIP, FPR
  2. The report dates are monthly during the first years of the reference simulation and every 6 months towards the last years. This causes the frequency of observations extracted from the reference simulation for the FlowNet runs to vary too much, which ends up giving too much weight on matching the reference simulation at earlier dates. We should enable monthly report dates throughout the entire simulated period. This will also improve the use of the resampling option to vary the frequency of the observations used for training the FlowNet ensemble
@edubarrosTNO
Copy link
Contributor Author

@wouterjdb, I assigned this issue to you because for some reason I couldn't assign @olwijn. But now he is tagged here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants