Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoding of pressure limits #1720

Open
Eddasol opened this issue Aug 14, 2024 · 1 comment
Open

Remove hardcoding of pressure limits #1720

Eddasol opened this issue Aug 14, 2024 · 1 comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Aug 14, 2024

Describe the improvement you would like to see
Rewrite pressureSection to remove hardcoding of the pressure limits
image

Also suggest changing such that the pressureTable isn't only for taurobInspector, but for all robot types with pressure

How will this change existing functionality?

How will this improvement affect the current Threat Model?

@Eddasol Eddasol added the improvement Improvement to existing functionality label Aug 14, 2024
@tsundvoll tsundvoll added the good first issue Good for newcomers label Aug 26, 2024
@andchiind
Copy link
Contributor

Perhaps the warning range should be stored in the ISAR config which is sent to the backend and stored in the robot object? This could then be passed on to the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants