Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everest detached wait_for_server gives AttributeError #8896

Open
3 of 13 tasks
yngve-sk opened this issue Oct 7, 2024 · 1 comment · May be fixed by #8898
Open
3 of 13 tasks

everest detached wait_for_server gives AttributeError #8896

yngve-sk opened this issue Oct 7, 2024 · 1 comment · May be fixed by #8898
Assignees
Labels

Comments

@yngve-sk
Copy link
Contributor

yngve-sk commented Oct 7, 2024

(Should be looked at closer/discussed wrt current queue logic)

https://github.com/equinor/komodo-releases/actions/runs/11206504766/job/31147828376
Happens when running egg example and when the everserver doesn't start/submit to the queue as it should.

What happened? (You can include a screenshot if it helps explain)

Happens due to this:

            # Job queueing may fail:
            if context is not None and context.has_job_failed(0):
                path = context.job_progress(0).steps[0].std_err_file

where context.job_progress(0) returns None, whilst this code expects it to always be a list. It returns None from BatchSimulatorContext.job_progress:

        if (
            iens not in self._scheduler._jobs
            or self._scheduler._jobs[iens].state == JobState.WAITING
        ):
            return None

If this case is true, it should somehow be handled more gracefully, and the error should be more descriptive. We also don't know if it was due to the scheduler not having an entry for that iens or if the job was in JobState.WAITING.

What did you expect to happen?

A more descriptive error and/or graceful handling in wait_for_server.

steps to reproduce

No response

Environment where bug has been observed

  • python 3.8
  • python 3.9
  • python 3.10
  • python 3.11
  • python 3.12
  • macosx
  • rhel7
  • rhel8
  • local queue
  • lsf queue
  • slurm queue
  • openPBS queue
  • used flag --enable-scheduler
@yngve-sk yngve-sk added the bug label Oct 7, 2024
@yngve-sk yngve-sk linked a pull request Oct 7, 2024 that will close this issue
9 tasks
@yngve-sk
Copy link
Contributor Author

yngve-sk commented Oct 9, 2024

Will likely be addressed/deprecated by making Everserver use EnsembleEvaluator @ #8905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

1 participant