-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate releases #347
Comments
Also the release build should set the linker flags with the tag version and shas. See: otel-cli/.github/workflows/ci.yml Line 21 in 92a6f0a
|
goreleaser should be setting the three linker flags automatically for release builds but for clarity there are three: The variables are defined in main.go: https://github.com/equinix-labs/otel-cli/blob/main/main.go |
Instructions are in the Releases section of the README.md. A GitHub action could be used to trigger the tag and release. In other Equinix and Equinix Labs projects, Conventional Commits and Semantic Release have been introduced to simplify this process and ensure that the correct semver revision is applied based on the commit messages. CI will fail of conventional commits are not used. Maintainers reviewing PRs must ensure the prefixes ( The Equinix Go SDK and Terraform providers follow this pattern. |
Releases follow semantic versioning since v0.0.1 and I've been writing a CHANGELOG.md for the last few releases. There have been no other maintainers to coordinate with so I feel the conventions are not as valuable as they are in a larger project context. For this project, releasing on tag push makes the most sense to me. I now work on this in my personal time for free, and would prefer to not have the overhead. My feeling is that choices about how to maintain as a team should be made by that team when/if it materializes. For now, keeping the barrier to submitting & reviewing PRs low is paramount. |
An on-push GitHub Actions workflow should have write access to packages and releases, no need to mint a personal token. You may want to explicitly specify the |
Now that otel-cli has a good functional testing story, it's time to finally automate the last bits of the release process to get my computer out of the loop. I believe the remaining steps are something like this:
go test -v
which will run functional tests to validate the tagOnce this is complete, a release can be made by tagging a sha and pushing tags, so package & release write access can be restricted to actions only.
The text was updated successfully, but these errors were encountered: