Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version bump auto-commit in release job #159

Open
ctreatma opened this issue Oct 10, 2023 · 0 comments
Open

Fix version bump auto-commit in release job #159

ctreatma opened this issue Oct 10, 2023 · 0 comments

Comments

@ctreatma
Copy link
Contributor

The push-button release job figures out the correct version for the next release, writes that to the version file, regenerates the SDK, and then commits the changes to main so that the release can be tagged.

We use the git plugin for semantic-release to commit the version bump changes; unfortunately this plugin uses an assets array to specify commit assets, and bypasses .gitignore when determining what files to commit.

The assets array we currently use appears to be too narrow; as a result, a recent sync job opened a PR that included no spec changes (because the SDK is up-to-date with the API spec), but included changes related to the most recent version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant