From 47fdf334cf160b9ce64c9a22267ce323616b5f01 Mon Sep 17 00:00:00 2001 From: William Patton Date: Tue, 25 Jun 2024 23:32:00 +0100 Subject: [PATCH 01/12] Add a class on the settings page container when pro callout will show --- partials/settings-page.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/partials/settings-page.php b/partials/settings-page.php index 0e83afc9..1f76b38f 100644 --- a/partials/settings-page.php +++ b/partials/settings-page.php @@ -45,7 +45,7 @@ function ( $a, $b ) { $settings_tab = ( array_search( $settings_tab, array_column( $settings_tab_items, 'slug' ), true ) !== false ) ? $settings_tab : $default_tab; ?> -
+

From d136c6e4dc806087f374746418cea4173268f138 Mon Sep 17 00:00:00 2001 From: William Patton Date: Tue, 25 Jun 2024 23:32:29 +0100 Subject: [PATCH 02/12] Add a style rule to allow settings page to grow if pro callout will be in it --- src/admin/sass/accessibility-checker-admin.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/admin/sass/accessibility-checker-admin.scss b/src/admin/sass/accessibility-checker-admin.scss index 37e55141..7d77c620 100644 --- a/src/admin/sass/accessibility-checker-admin.scss +++ b/src/admin/sass/accessibility-checker-admin.scss @@ -820,6 +820,11 @@ .edac-settings { max-width: 800px; + + &.pro-callout-wrapper { + max-width: fit-content; + } + .edac-description { font-size: 13px; } From cdd9bc04801c91c2dad76de9ba654eefd4fcd445 Mon Sep 17 00:00:00 2001 From: William Patton Date: Tue, 25 Jun 2024 23:35:27 +0100 Subject: [PATCH 03/12] Version bump 1.14.1 --- accessibility-checker.php | 4 ++-- package.json | 2 +- readme.txt | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/accessibility-checker.php b/accessibility-checker.php index 09a15076..2a8a1a13 100755 --- a/accessibility-checker.php +++ b/accessibility-checker.php @@ -10,7 +10,7 @@ * Plugin Name: Accessibility Checker * Plugin URI: https://a11ychecker.com * Description: Audit and check your website for accessibility before you hit publish. In-post accessibility scanner and guidance. - * Version: 1.14.0 + * Version: 1.14.1 * Author: Equalize Digital * Author URI: https://equalizedigital.com * License: GPL-2.0+ @@ -35,7 +35,7 @@ // Current plugin version. if ( ! defined( 'EDAC_VERSION' ) ) { - define( 'EDAC_VERSION', '1.14.0' ); + define( 'EDAC_VERSION', '1.14.1' ); } // Current database version. diff --git a/package.json b/package.json index f5ffe407..e70e5885 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "accessibility-checker", - "version": "1.14.0", + "version": "1.14.1", "description": "Audit and check your website for accessibility before you hit publish. In-post accessibility scanner and guidance.", "author": "Equalize Digital", "license": "GPL-2.0+", diff --git a/readme.txt b/readme.txt index c3e49220..8d8d7b81 100644 --- a/readme.txt +++ b/readme.txt @@ -171,6 +171,9 @@ No, Accessibility Checker runs completely on your server and does not require yo == Changelog == += 1.14.1 = +* Fixed: Prevent settings page layout issue + = 1.14.0 = * Added: Option to move front-end highlighter to opposite side of the window * Fixed: Prevent image from overspilling container in issue view From 8253507c3f4d9b0962857bd41737ea8f223bc9e4 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Wed, 26 Jun 2024 15:38:05 +0100 Subject: [PATCH 04/12] Reorder some css for better readability and discoverability when editing --- src/frontendHighlighterApp/sass/app.scss | 82 ++++++++++++------------ 1 file changed, 40 insertions(+), 42 deletions(-) diff --git a/src/frontendHighlighterApp/sass/app.scss b/src/frontendHighlighterApp/sass/app.scss index 25a1df5d..a1ca30a4 100644 --- a/src/frontendHighlighterApp/sass/app.scss +++ b/src/frontendHighlighterApp/sass/app.scss @@ -68,6 +68,45 @@ body { } &-panel{ + width: auto; + max-width: 400px !important; + position: fixed !important; + z-index: 2147483647 !important; + bottom: 15px !important; + + @media screen and (max-width: $small-screen-width ) { + width: 100%; + max-width: calc(100% - 30px) !important; + } + + @media screen and (max-width: $extra-small-screen-width ) { + + .edac-highlight-panel-controls-buttons { + // display: flex !important; + justify-content: space-around; + + button { + padding: 4px 7px !important; + margin-right: 0px !important; + } + } + + } + + @media screen and (max-width: calc($extra-small-screen-width ) ) { + + .edac-highlight-panel-controls-buttons { + display: flex !important; + justify-content: space-around; + + button { + padding: 4px 7px !important; + margin-right: 0px !important; + } + } + + } + * { all: unset; } @@ -77,12 +116,6 @@ body { color: $color-white !important; } - width: auto; - max-width: 400px !important; - position: fixed !important; - z-index: 2147483647 !important; - bottom: 15px !important; - &--right { right: 15px !important; } @@ -110,6 +143,7 @@ body { outline: solid 5px rgba(0,208,255,.75) !important; } } + &-description { max-height: calc( 100vh - 230px ) !important; display: block; @@ -292,42 +326,6 @@ body { } } } - - &-panel { - @media screen and (max-width: $small-screen-width ) { - width: 100%; - max-width: calc(100% - 30px) !important; - } - - @media screen and (max-width: $extra-small-screen-width ) { - - .edac-highlight-panel-controls-buttons { - // display: flex !important; - justify-content: space-around; - - button { - padding: 4px 7px !important; - margin-right: 0px !important; - } - } - - } - - @media screen and (max-width: calc($extra-small-screen-width ) ) { - - .edac-highlight-panel-controls-buttons { - display: flex !important; - justify-content: space-around; - - button { - padding: 4px 7px !important; - margin-right: 0px !important; - } - } - - } - - } } From afb9d04dcae01a258c6cbf90fffec5fdebe11228 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Wed, 26 Jun 2024 15:53:39 +0100 Subject: [PATCH 05/12] Don't float the toggle button unless it inside a right side panel --- src/frontendHighlighterApp/sass/app.scss | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/frontendHighlighterApp/sass/app.scss b/src/frontendHighlighterApp/sass/app.scss index a1ca30a4..0489a7b4 100644 --- a/src/frontendHighlighterApp/sass/app.scss +++ b/src/frontendHighlighterApp/sass/app.scss @@ -137,11 +137,16 @@ body { box-shadow: 0 0 5px rgba($color-black,.5) !important; border-radius: 50% !important; position: relative !important; - float: right !important; &:hover, &:focus { cursor: pointer !important; outline: solid 5px rgba(0,208,255,.75) !important; } + + @media screen and (max-width: $small-screen-width ) { + .edac-highlight-panel--right & { + float: right !important; + } + } } &-description { From 9b5450714a3229a88ead352ec58f88c72e35d6d5 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Wed, 26 Jun 2024 16:00:05 +0100 Subject: [PATCH 06/12] Reformat this CSS file for consistent spacing and indentation --- src/frontendHighlighterApp/sass/app.scss | 598 ++++++++++++----------- 1 file changed, 315 insertions(+), 283 deletions(-) diff --git a/src/frontendHighlighterApp/sass/app.scss b/src/frontendHighlighterApp/sass/app.scss index 0489a7b4..22897783 100644 --- a/src/frontendHighlighterApp/sass/app.scss +++ b/src/frontendHighlighterApp/sass/app.scss @@ -1,72 +1,75 @@ -@import "../../common/sass/variables" ; +@import "../../common/sass/variables"; @import "../../common/sass/helpers"; - body { - &.edac-app-disable-styles { - // padding: .5rem (46px + 46px ) !important; //make sure button is visible - #wpadminbar { display: none !important; } - } - - &.edac-app-wait * { - cursor: wait !important; - } + &.edac-app-disable-styles { + // padding: .5rem (46px + 46px ) !important; //make sure button is visible + #wpadminbar { + display: none !important; + } + } + + &.edac-app-wait * { + cursor: wait !important; + } } .edac-highlight { - all: unset; - - * { - all: unset; - } - - - display: inline-block; - clear: both; - - - &-element-selected{ - outline: dashed 4px transparent !important; - outline-offset: 5px !important; - outline-color: magenta !important; - - &-min-width { - min-width: 25px !important; - display: inline-block !important; - } - &-min-height { - min-height: 16px !important; - } - } - - &-btn{ - all: unset; - width: 40px !important; - height: 40px !important; - display: block !important; - font-size: 0 !important; - border-radius: 50% !important; - margin: 5px !important; - position: absolute !important; - z-index: 2147483646 !important; - - &-error{ - background: transparent url("../images/highlight-icon-error.svg") center center no-repeat !important; - background-size: 40px 40px !important; - } - &-warning{ - background: transparent url("../images/highlight-icon-warning.svg") center center no-repeat !important; - } - &-ignored{ - background: transparent url("../images/highlight-icon-ignored.svg") center center no-repeat !important; - } - - &-selected, &:hover, &:focus { - outline: solid 5px rgba(0,208,255,.75) !important; - } - } - &-panel{ + all: unset; + + * { + all: unset; + } + + display: inline-block; + clear: both; + + &-element-selected { + outline: dashed 4px transparent !important; + outline-offset: 5px !important; + outline-color: magenta !important; + + &-min-width { + min-width: 25px !important; + display: inline-block !important; + } + + &-min-height { + min-height: 16px !important; + } + } + + &-btn { + all: unset; + width: 40px !important; + height: 40px !important; + display: block !important; + font-size: 0 !important; + border-radius: 50% !important; + margin: 5px !important; + position: absolute !important; + z-index: 2147483646 !important; + + &-error { + background: transparent url("../images/highlight-icon-error.svg") center center no-repeat !important; + background-size: 40px 40px !important; + } + + &-warning { + background: transparent url("../images/highlight-icon-warning.svg") center center no-repeat !important; + } + + &-ignored { + background: transparent url("../images/highlight-icon-ignored.svg") center center no-repeat !important; + } + + &-selected, &:hover, &:focus { + outline: solid 5px rgba(0, 208, 255, .75) !important; + } + } + + &-panel { width: auto; max-width: 400px !important; @@ -74,12 +77,12 @@ body { z-index: 2147483647 !important; bottom: 15px !important; - @media screen and (max-width: $small-screen-width ) { + @media screen and (max-width: $small-screen-width) { width: 100%; max-width: calc(100% - 30px) !important; } - @media screen and (max-width: $extra-small-screen-width ) { + @media screen and (max-width: $extra-small-screen-width) { .edac-highlight-panel-controls-buttons { // display: flex !important; @@ -93,7 +96,7 @@ body { } - @media screen and (max-width: calc($extra-small-screen-width ) ) { + @media screen and (max-width: calc($extra-small-screen-width)) { .edac-highlight-panel-controls-buttons { display: flex !important; @@ -107,14 +110,14 @@ body { } - * { - all: unset; - } + * { + all: unset; + } - a:not(.edac-highlight-panel-description-reference) { - all: revert !important; - color: $color-white !important; - } + a:not(.edac-highlight-panel-description-reference) { + all: revert !important; + color: $color-white !important; + } &--right { right: 15px !important; @@ -124,233 +127,262 @@ body { left: 15px !important; } - &-visible { - width: 400px !important; - } - - &-toggle{ - width: 50px !important; - height: 50px !important; - display: block; - background: transparent url("../images/edac-emblem.png") center center no-repeat !important; - background-size: contain !important; - box-shadow: 0 0 5px rgba($color-black,.5) !important; - border-radius: 50% !important; - position: relative !important; - &:hover, &:focus { - cursor: pointer !important; - outline: solid 5px rgba(0,208,255,.75) !important; - } - - @media screen and (max-width: $small-screen-width ) { + &-visible { + width: 400px !important; + } + + &-toggle { + width: 50px !important; + height: 50px !important; + display: block; + background: transparent url("../images/edac-emblem.png") center center no-repeat !important; + background-size: contain !important; + box-shadow: 0 0 5px rgba($color-black, .5) !important; + border-radius: 50% !important; + position: relative !important; + + &:hover, &:focus { + cursor: pointer !important; + outline: solid 5px rgba(0, 208, 255, .75) !important; + } + + @media screen and (max-width: $small-screen-width) { .edac-highlight-panel--right & { float: right !important; } } - } - - &-description { - max-height: calc( 100vh - 230px ) !important; - display: block; - border: solid 1px $color-gray-light !important; - background-color: $color-white !important; - margin-bottom: 15px !important; - padding: 15px !important; - color: $color-white !important; - background-color: $color-blue-dark !important; - font-size: 14px !important; - line-height: 22px !important; - font-family: sans-serif !important; - text-align: left !important; - display: none; - overflow-y: scroll !important; - box-shadow: 0px 0px 5px rgba($color-black, .25) !important; - -webkit-font-smoothing: antialiased !important; - -moz-osx-font-smoothing: grayscale !important; - &:focus { - //outline: solid 5px rgba(0,208,255,.75); - } - &-title{ - font-size: 16px !important; - display: block !important; - font-weight: bold !important; - margin-bottom: 5px !important; - } - &-type{ - font-size: 12px !important; - padding: 5px 7px !important; - border-radius: 4px !important; - font-size: 12px !important; - line-height: 12px !important; - margin-left: 10px !important; - display: inline-block !important; - text-transform: capitalize !important; - position: relative !important; - top: -2px !important; - &-error{ - color: $color-white !important; - background-color: $color-red !important; - } - &-warning{ - color: $color-blue-dark !important; - background-color: $color-yellow !important; - } - &-ignored{ - color: $color-white !important; - background-color: $color-blue !important; - } - } - &-index{ - font-size: 16px !important; - display: block !important; - font-weight: bold !important; - margin-bottom: 5px !important; - } - &-status{ - color: $color-white !important; - display: block !important; - background-color: $color-red !important; - padding: 10px 15px !important; - margin-top: 10px !important; - margin-bottom: 10px !important; - } - &-reference, - &-code-button{ - all: unset; - color: $color-blue-dark !important; - background-color: $color-yellow !important; - padding: 4px 10px !important; - display: inline-block !important; - margin-top: 10px !important; - margin-right: 10px !important; - &:hover, &:focus, &[aria-expanded="true"]{ - color: $color-blue-dark !important; - background-color: $color-white !important; - cursor: pointer !important; - } - } - &-reference{ - text-decoration: none !important; - } - &-code-button{ - } - &-code{ - color: $color-black !important; - display: block; - background-color: $color-white !important; - padding: 10px 15px !important; - display: none; - margin-top: 10px !important; - } - &-close{ - width: 25px !important; - height: 25px !important; - color: $color-blue-dark !important; - background-color: $color-yellow !important; - font-size: 18px !important; - line-height: 25px !important; - position: absolute !important; - top: 1px !important; - right: 1px !important; - text-align: center !important; - &:hover, &:focus{ - cursor: pointer !important; - color: $color-blue-dark !important; - background-color: $color-white !important; - } - } - } - &-controls { - color: $color-white !important; - display: block; - background-color: $color-blue !important; - border: solid 1px $color-gray-light !important; - display: none; - box-shadow: 0px 0px 5px rgba($color-black, .15) !important; - position: relative !important; - padding: 15px !important; - font-size: 14px !important; - line-height: 22px !important; - font-family: sans-serif !important; - -webkit-font-smoothing: antialiased !important; - -moz-osx-font-smoothing: grayscale !important; - &:focus { - // outline: solid 1px rgba(0,208,255,.75); - } - &-title{ - font-size: 16px !important; - display: block !important; - font-weight: bold !important; - margin-bottom: 5px !important; - } - &-close{ - width: 25px !important; - height: 25px !important; - color: $color-blue-dark !important; - background-color: $color-yellow !important; - font-size: 18px !important; - line-height: 25px !important; - position: absolute !important; - top: 0px !important; - right: 0px !important; - text-align: center !important; - &:hover, &:focus{ - cursor: pointer !important; - color: $color-blue-dark !important; - background-color: $color-white !important; - } - } - &-summary{ - display: block !important; - } - &-buttons{ - display: grid !important; - grid-template-columns: repeat(2, 1fr) !important; - button{ - all: unset; - color: $color-white !important; - background-color: $color-blue-dark !important; - padding: 4px 10px !important; - display: inline-block !important; - margin-top: 10px !important; - margin-right: 10px !important; - &:hover, &:focus{ - color: $color-blue-dark !important; - background-color: $color-white !important; - cursor: pointer !important; - } - &:disabled { - display: none !important; - } - - } - } - .edac-highlight-disable-styles{ - float: right !important; - margin-right: 0 !important; - } - } - } + } + + &-description { + max-height: calc(100vh - 230px) !important; + display: block; + border: solid 1px $color-gray-light !important; + background-color: $color-white !important; + margin-bottom: 15px !important; + padding: 15px !important; + color: $color-white !important; + background-color: $color-blue-dark !important; + font-size: 14px !important; + line-height: 22px !important; + font-family: sans-serif !important; + text-align: left !important; + display: none; + overflow-y: scroll !important; + box-shadow: 0px 0px 5px rgba($color-black, .25) !important; + -webkit-font-smoothing: antialiased !important; + -moz-osx-font-smoothing: grayscale !important; + + &:focus { + //outline: solid 5px rgba(0,208,255,.75); + } + + &-title { + font-size: 16px !important; + display: block !important; + font-weight: bold !important; + margin-bottom: 5px !important; + } + + &-type { + font-size: 12px !important; + padding: 5px 7px !important; + border-radius: 4px !important; + font-size: 12px !important; + line-height: 12px !important; + margin-left: 10px !important; + display: inline-block !important; + text-transform: capitalize !important; + position: relative !important; + top: -2px !important; + + &-error { + color: $color-white !important; + background-color: $color-red !important; + } + + &-warning { + color: $color-blue-dark !important; + background-color: $color-yellow !important; + } + + &-ignored { + color: $color-white !important; + background-color: $color-blue !important; + } + } + + &-index { + font-size: 16px !important; + display: block !important; + font-weight: bold !important; + margin-bottom: 5px !important; + } + + &-status { + color: $color-white !important; + display: block !important; + background-color: $color-red !important; + padding: 10px 15px !important; + margin-top: 10px !important; + margin-bottom: 10px !important; + } + + &-reference, + &-code-button { + all: unset; + color: $color-blue-dark !important; + background-color: $color-yellow !important; + padding: 4px 10px !important; + display: inline-block !important; + margin-top: 10px !important; + margin-right: 10px !important; + + &:hover, &:focus, &[aria-expanded="true"] { + color: $color-blue-dark !important; + background-color: $color-white !important; + cursor: pointer !important; + } + } + + &-reference { + text-decoration: none !important; + } + + &-code-button { + } + + &-code { + color: $color-black !important; + display: block; + background-color: $color-white !important; + padding: 10px 15px !important; + display: none; + margin-top: 10px !important; + } + + &-close { + width: 25px !important; + height: 25px !important; + color: $color-blue-dark !important; + background-color: $color-yellow !important; + font-size: 18px !important; + line-height: 25px !important; + position: absolute !important; + top: 1px !important; + right: 1px !important; + text-align: center !important; + + &:hover, &:focus { + cursor: pointer !important; + color: $color-blue-dark !important; + background-color: $color-white !important; + } + } + } + + &-controls { + color: $color-white !important; + display: block; + background-color: $color-blue !important; + border: solid 1px $color-gray-light !important; + display: none; + box-shadow: 0px 0px 5px rgba($color-black, .15) !important; + position: relative !important; + padding: 15px !important; + font-size: 14px !important; + line-height: 22px !important; + font-family: sans-serif !important; + -webkit-font-smoothing: antialiased !important; + -moz-osx-font-smoothing: grayscale !important; + + &:focus { + // outline: solid 1px rgba(0,208,255,.75); + } + + &-title { + font-size: 16px !important; + display: block !important; + font-weight: bold !important; + margin-bottom: 5px !important; + } + + &-close { + width: 25px !important; + height: 25px !important; + color: $color-blue-dark !important; + background-color: $color-yellow !important; + font-size: 18px !important; + line-height: 25px !important; + position: absolute !important; + top: 0px !important; + right: 0px !important; + text-align: center !important; + + &:hover, &:focus { + cursor: pointer !important; + color: $color-blue-dark !important; + background-color: $color-white !important; + } + } + + &-summary { + display: block !important; + } + + &-buttons { + display: grid !important; + grid-template-columns: repeat(2, 1fr) !important; + + button { + all: unset; + color: $color-white !important; + background-color: $color-blue-dark !important; + padding: 4px 10px !important; + display: inline-block !important; + margin-top: 10px !important; + margin-right: 10px !important; + + &:hover, &:focus { + color: $color-blue-dark !important; + background-color: $color-white !important; + cursor: pointer !important; + } + + &:disabled { + display: none !important; + } + + } + } + + .edac-highlight-disable-styles { + float: right !important; + margin-right: 0 !important; + } + } + } } .notyf { - z-index: 2147483647 !important; + z-index: 2147483647 !important; } + .notyf__toast { - max-width: 100% !important; + max-width: 100% !important; } + .notyf__message { - color: #000000; + color: #000000; } .notyf__dismiss-btn:before, .notyf__dismiss-btn:after { - background: #000000 !important; + background: #000000 !important; } .edac-accessibility-statement { - text-align: center; - max-width: 800px; - margin: auto; - padding: 15px; + text-align: center; + max-width: 800px; + margin: auto; + padding: 15px; } From a0ed1b5aa4c02007eb9f098fd7f7cbf6935c4555 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Wed, 26 Jun 2024 23:24:09 +0100 Subject: [PATCH 07/12] Use a selector that excludes html, head and body from the initial list --- src/pageScanner/rules/underlined-text.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pageScanner/rules/underlined-text.js b/src/pageScanner/rules/underlined-text.js index 193bcda6..c300ef1f 100644 --- a/src/pageScanner/rules/underlined-text.js +++ b/src/pageScanner/rules/underlined-text.js @@ -8,6 +8,7 @@ export default { id: 'underlined_text', impact: 'moderate', + selector: '*:not(a):not(html):not(head):not(body)', matches: ( element ) => { return ( ! element.hasAttribute( 'href' ) || From 61fee2f5e15deeaf5db73d8c7d6e19918b861370 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Wed, 26 Jun 2024 23:24:56 +0100 Subject: [PATCH 08/12] Check parent nodes to see if the element is inside an anchor If it's in an anchor then underline is valid and shouldn't flag. It checks up the tree 3 levels --- src/pageScanner/rules/underlined-text.js | 26 ++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/src/pageScanner/rules/underlined-text.js b/src/pageScanner/rules/underlined-text.js index c300ef1f..64c55935 100644 --- a/src/pageScanner/rules/underlined-text.js +++ b/src/pageScanner/rules/underlined-text.js @@ -10,10 +10,28 @@ export default { impact: 'moderate', selector: '*:not(a):not(html):not(head):not(body)', matches: ( element ) => { - return ( - ! element.hasAttribute( 'href' ) || - element.tagName.toLowerCase() === 'u' - ); + // U tags we will always check. + if ( element.tagName.toLowerCase() === 'u' ) { + return true; + } + + // Traverse up the dom 3 levels and check if the element is inside an anchor. + let parent = element.parentNode; + let isInsideAnchor = false; + for ( let i = 0; i < 3; i++ ) { + // can't go further up the dom if the parent is the html element. + if ( parent.tagName.toLowerCase() === 'html' ) { + break; + } + if ( parent && parent.tagName.toLowerCase() === 'a' ) { + isInsideAnchor = true; + break; + } + parent = parent.parentNode; + } + + // If in an anchor, don't check underline. + return ! isInsideAnchor; }, tags: [ 'wcag324', 'wcag21aa', 'cat.text', 'custom' ], metadata: { From da477fb05a3a1b869600e9eb53475e6bf544cc51 Mon Sep 17 00:00:00 2001 From: William Patton Date: Wed, 26 Jun 2024 23:30:58 +0100 Subject: [PATCH 09/12] Update src/pageScanner/rules/underlined-text.js --- src/pageScanner/rules/underlined-text.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pageScanner/rules/underlined-text.js b/src/pageScanner/rules/underlined-text.js index 64c55935..afa42618 100644 --- a/src/pageScanner/rules/underlined-text.js +++ b/src/pageScanner/rules/underlined-text.js @@ -19,7 +19,7 @@ export default { let parent = element.parentNode; let isInsideAnchor = false; for ( let i = 0; i < 3; i++ ) { - // can't go further up the dom if the parent is the html element. + // Can't go further up the dom if the parent is the html element. if ( parent.tagName.toLowerCase() === 'html' ) { break; } From 594da0a451477bdbb93b11634d4445b18be85311 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Thu, 27 Jun 2024 15:00:21 +0100 Subject: [PATCH 10/12] Bump version 1.14.1 -> 1.14.2 --- accessibility-checker.php | 4 ++-- package.json | 2 +- readme.txt | 4 ++++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/accessibility-checker.php b/accessibility-checker.php index 2a8a1a13..ee46a7e8 100755 --- a/accessibility-checker.php +++ b/accessibility-checker.php @@ -10,7 +10,7 @@ * Plugin Name: Accessibility Checker * Plugin URI: https://a11ychecker.com * Description: Audit and check your website for accessibility before you hit publish. In-post accessibility scanner and guidance. - * Version: 1.14.1 + * Version: 1.14.2 * Author: Equalize Digital * Author URI: https://equalizedigital.com * License: GPL-2.0+ @@ -35,7 +35,7 @@ // Current plugin version. if ( ! defined( 'EDAC_VERSION' ) ) { - define( 'EDAC_VERSION', '1.14.1' ); + define( 'EDAC_VERSION', '1.14.2' ); } // Current database version. diff --git a/package.json b/package.json index e70e5885..49d3e8b4 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "accessibility-checker", - "version": "1.14.1", + "version": "1.14.2", "description": "Audit and check your website for accessibility before you hit publish. In-post accessibility scanner and guidance.", "author": "Equalize Digital", "license": "GPL-2.0+", diff --git a/readme.txt b/readme.txt index 8d8d7b81..2c2d47e7 100644 --- a/readme.txt +++ b/readme.txt @@ -171,6 +171,10 @@ No, Accessibility Checker runs completely on your server and does not require yo == Changelog == += 1.15.0 = +* Fixed: Frontend highlighter could not be moved to the right side of the window on mobile +* Enhancement: Reduce false positives for underlined text check + = 1.14.1 = * Fixed: Prevent settings page layout issue From 809aecc034c00bef93185ad0741d07b5caeb77a3 Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Thu, 27 Jun 2024 15:16:07 +0100 Subject: [PATCH 11/12] Fix query where object was mistakenly used in WHERE clause Issue cased in e9541a8de0fd8f8a5e5a6d1fa7f11c0b6273da69 --- admin/class-ajax.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/class-ajax.php b/admin/class-ajax.php index 2b943416..ad8f0b90 100644 --- a/admin/class-ajax.php +++ b/admin/class-ajax.php @@ -684,7 +684,7 @@ function ( $value ) { // For small batches of IDs, we can just loop through. foreach ( $ids as $id ) { // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching -- Safe variable used for table name, caching not required for one time operation. - $wpdb->query( $wpdb->prepare( 'UPDATE %i SET ignre = %d, ignre_user = %d, ignre_date = %s, ignre_comment = %s, ignre_global = %d WHERE siteid = %d and object = %d', $table_name, $ignre, $ignre_user, $ignre_date, $ignre_comment, $ignore_global, $siteid, $id ) ); + $wpdb->query( $wpdb->prepare( 'UPDATE %i SET ignre = %d, ignre_user = %d, ignre_date = %s, ignre_comment = %s, ignre_global = %d WHERE siteid = %d and id = %d', $table_name, $ignre, $ignre_user, $ignre_date, $ignre_comment, $ignore_global, $siteid, $id ) ); } } From 5c1ec399a4182f77dee90ba997ed2ed62e51098c Mon Sep 17 00:00:00 2001 From: pattonwebz Date: Thu, 27 Jun 2024 15:21:31 +0100 Subject: [PATCH 12/12] Add changelog for 1.14.2 --- readme.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/readme.txt b/readme.txt index 2c2d47e7..f64644d1 100644 --- a/readme.txt +++ b/readme.txt @@ -171,9 +171,10 @@ No, Accessibility Checker runs completely on your server and does not require yo == Changelog == -= 1.15.0 = -* Fixed: Frontend highlighter could not be moved to the right side of the window on mobile += 1.14.2 = * Enhancement: Reduce false positives for underlined text check +* Fixed: Frontend highlighter could not be moved to the right side of the window on mobile +* Fixed: Issue where ignores were not being saved and failing silently = 1.14.1 = * Fixed: Prevent settings page layout issue