New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default DOI extraction #13

Open

jesusbagpuss opened this issue Dec 1, 2023 · 0 comments

Assignees

Contributor

jesusbagpuss commented Dec 1, 2023

If someone has entered a DOI resolver URL into the id_number field, the Altmetric badge will fail, as this:

altmetric/cfg/cfg.d/z_altmetric.pl

Lines 37 to 41 in a9cb2a2

    
           # id_numbers that have 10. in them (rudimentary doi check) 
        
                 if( $eprint->exists_and_set( "id_number" ) && ( $eprint->value( "id_number" ) =~ /\b10./ ) ){ 
        
                         return( "doi", $eprint->value( "id_number" ) );	 
        
           }

will return the URL, not the DOI from the URL.

jesusbagpuss self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment