Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module 2 Skip Logic or Saving Issue: MENSHIS2_1 and MENSHIS5 #440

Open
KELSEYDOWLING7 opened this issue Dec 2, 2024 · 12 comments
Open

Module 2 Skip Logic or Saving Issue: MENSHIS2_1 and MENSHIS5 #440

KELSEYDOWLING7 opened this issue Dec 2, 2024 · 12 comments

Comments

@KELSEYDOWLING7
Copy link
Collaborator

KELSEYDOWLING7 commented Dec 2, 2024

Based on the skip logic in the Qx document and QC rules, if MENSHISA is less than 0 or null, MENSHIS2_1 must be null. Same logic applies to MENSHIS5.

However these participants with null MENSHISA values were able to answer MENSHIS2_1:
4477623862 2025262984 5804126258 1454524180 7132444744 9621192890 6749884374 9880878735 9871441063 5195870819 8984301161 9236220854 9537726454 7928349908 2006727084 3497276532 9817027098 5585167438

And these participants with MENSHISA null values were able to answer MENSHIS5:
2025262984 5585167438 7928349908 1454524180 2261805341 9621192890 9579489549 9030288749 9871441063 9282536005 2907887692 1108663459 9880878735 9236220854 5342664636 5195870819 9537726454 7132444744 8984301161 2006727084 6749884374 3497276532 9817027098 7214144756 1223732780 4477623862

There is either an issue with the response value being saved for MENSHISA or a skip flow issue. I see a comment that the MENSHIS5 logic was changed last year, but it doesn't seem as though either question should be seen if MENSHISA is null. There are cases where Module 2 was completed as recent as last week or as old as 2022, so it seems like these have been consistent issues.

@KELSEYDOWLING7
Copy link
Collaborator Author

I was unsure who in IMS to tag, as well as who is who by the usernames. Feel free to add or remove people tagged as needed

@boyd-mj
Copy link
Collaborator

boyd-mj commented Dec 2, 2024

You got everyone, thanks Kelsey!

@joshid-ims
Copy link
Collaborator

I could not reproduce the issue for MENSHIS2_1 but logic needs to be changed for MENSHIS5.

Can you please tell what exactly was entered in case of MENSHIS2_1 issue?

@KELSEYDOWLING7
Copy link
Collaborator Author

In the case of MENSHIS2_1, if a participant does not answer with an age in MENSHISA, they should not be able to see MENSHIS2_1. For the participants listed above, they all saw and answered MENSHIS2_1 without a MENSHISA value entered

@joshid-ims
Copy link
Collaborator

Yea, that is what I am not able to reproduce. I tried both, selected 44 and also chose not to answer MENSHISA.

@KELSEYDOWLING7
Copy link
Collaborator Author

Ok that one might be a saving issue then. Meaning its possible they answered MENSHISA but we somehow don't have the data.

@anthonypetersen is this something you or your team would be able to check? This may be linked to the data saving fail we discovered in this issue with Daniel: episphere/connect#1110

@joshid-ims
Copy link
Collaborator

Is this change going to be added to Word document? It is not there currently for MENSHIS5.

image

This is how it was coded first.

@KELSEYDOWLING7
Copy link
Collaborator Author

Hmm I'm not sure. It looks like the markup and the QC rule are inconsistent then. "MENSHISA is less than 0 or null" could mean that MENSHIS_SCR=44 but not guaranteed.

@boyd-mj
Copy link
Collaborator

boyd-mj commented Dec 6, 2024

@KELSEYDOWLING7 could you check with your team and have Aileen make any changes to the questionnaire docs if content changes are needed? Thanks.

@KELSEYDOWLING7
Copy link
Collaborator Author

@cunnaneaq Do you mind reviewing this skip flow logic?

@KELSEYDOWLING7
Copy link
Collaborator Author

KELSEYDOWLING7 commented Dec 9, 2024

Me and Aileen reviewed. It looks like the rule for MENSHIS5 is following the old skip flow pattern (skip flow chart below) but the order of the questions have been changed. MENSHIS9 is now before MENSHIS5. We're thinking the QC rule may need to be updated accordingly.
image

@cunnaneaq
Copy link
Collaborator

I agree that MENSHISA = null with responses seen fro MENSHIS2_1 looks like a saving issue according to the qx doc and @joshid-ims unable to reproduce.

I looked back at an old questionnaire document which matches Kelsey's flow chart above. Screenshots from the qx doc in prod are below

Screenshot 2024-12-09 at 3 12 12 PM

Screenshot 2024-12-09 at 3 10 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants