Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod 2: age range checks #422

Open
m-j-horner opened this issue Sep 25, 2024 · 12 comments
Open

mod 2: age range checks #422

m-j-horner opened this issue Sep 25, 2024 · 12 comments
Assignees
Labels
English Survey Use this label when indicating an issue in an English survey Mod2 Prod Push - SEPT. 24 Spanish Survey Use this label when indicating an issue is in a Spanish survey

Comments

@m-j-horner
Copy link
Collaborator

@joshid-ims @huip-ims
Module 2 English age range checks are updated: https://app.box.com/s/cqoq9qexq3dstzdr5p7v1vbe0ekel9ct

Module 2 Spanish age range checks are updated: https://app.box.com/s/3dcpco42ne5nzf0pqeg3qimhzrcl54dr

@m-j-horner m-j-horner added Mod2 Prod Push - SEPT. 24 Spanish Survey Use this label when indicating an issue is in a Spanish survey labels Sep 25, 2024
@joshid-ims
Copy link
Collaborator

Thanks!

@joshid-ims
Copy link
Collaborator

There is a range check for SHIFTWORK10 Years in English but not in Spanish. Should that be added?

image

image

@m-j-horner
Copy link
Collaborator Author

@joshid-ims oh yes! there should be a range check for calendar years in shiftwork. can you please copy and paste the english range check into the spanish?

good catch.

@joshid-ims
Copy link
Collaborator

Will do. Thanks!

@joshid-ims
Copy link
Collaborator

Are you going to make the change in the document? I do not think I can edit the document on Box. I will add it in code.

@woodruffr
Copy link
Collaborator

I added the range check to the Spanish M2 SHIFTWORK10 year text box. I also added the change log at the top. The formatting of the change log seems weird, but when I open it for editing, it is as expected.

@cunnaneaq
Copy link
Collaborator

thanks @woodruffr Spanish M2 SHIFTWORK10 age check looks good. I know what you mean about the log, I think it's fine for now!

@woodruffr
Copy link
Collaborator

Error in English document:

Combhor2 range check did not get updated to "age".
image

Issues with Spanish Questionnaire only:

SrvMRE_FirstPeriodAge_v1r0 should be MENSHIS in the range check.

English:
image

Spanish:
image

PROGHOR4 missing range check.

English:
image

Spanish:
image

@woodruffr woodruffr added the English Survey Use this label when indicating an issue in an English survey label Oct 25, 2024
@cunnaneaq
Copy link
Collaborator

Thanks for catching these! I made the updates in the English and Spanish qx docs

@woodruffr
Copy link
Collaborator

Thanks for the quick turn-around. I have reviewed the changes and they are as expected in the English and Spanish M2 Questionnaire.

@woodruffr
Copy link
Collaborator

@joshid-ims , I see you made the changes as expected already for these. This was just a documentation issue.

@cunnaneaq
Copy link
Collaborator

I updated the year range checks in the module 2 English and Spanish questionnaire documents to account for the change in #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
English Survey Use this label when indicating an issue in an English survey Mod2 Prod Push - SEPT. 24 Spanish Survey Use this label when indicating an issue is in a Spanish survey
Projects
None yet
Development

No branches or pull requests

5 participants