Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept Id 178420302 with redundant sources #12

Open
jonasalmeida opened this issue Mar 11, 2023 · 1 comment
Open

Concept Id 178420302 with redundant sources #12

jonasalmeida opened this issue Mar 11, 2023 · 1 comment
Assignees

Comments

@jonasalmeida
Copy link
Member

See https://github.com/episphere/conceptGithubActions/blob/master/jsons/178420302.json

I started using https://episphere.github.io/conceptutils to get a feeling for basic inconsistencies and this tool appears to make it fairly easy to assist with this. As agreed yesterday, suggestions of edits to the source of truth will be communicated as issues first and then assessed by designated curators, regardless of the permission level of the issue creator. I'd also suggest we use these issues to identify opportunities for improvement of the tool itself. For example, the redundancy in this concept would be easy to fix automatically by making sure all arrays in the concept id json structure have unique values. The corrected structure could then be created and committed to the clipboard to be pasted in github's editor. Do you want me to add that check for deviations to uniqueness in arrays with /\w+.json/ elements?

Here's the offending concept structure:

{
"conceptId": "178420302",
"Current Question Text": "Unavailable/Unknown",
"Primary Source": [
"692924902.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json",
"129084651.json"
],
"Secondary Source": [
"195399696.json",
"726699695.json",
"726699695.json",
"726699695.json",
"726699695.json",
"726699695.json",
"726699695.json",
"726699695.json",
"299215535.json",
"506648060.json",

...

@jonasalmeida
Copy link
Member Author

On the other hand, I see the "offending arrays" all have a fixed cardinality of 13 ... maybe this is not a mistake at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants