Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of no services case #178

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Handling of no services case #178

merged 1 commit into from
Nov 19, 2024

Conversation

marcelldls
Copy link
Collaborator

At the moment if we get_services and no services are present (this can also happen when all the services are being restarted) then we raise an error f"No ec-services found in {self.target}". This was OK for calling ec ps but would need to be handled by the monitor which calls the same function.

Here the empty dataframe is represented by an empty dataframe with a Schema which allows the various operations without needing to add guards

@gilesknap this is unchanged since we tested it on your machine

@marcelldls marcelldls requested a review from gilesknap November 18, 2024 12:31
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (dcb747c) to head (dc06a9f).

Files with missing lines Patch % Lines
src/edge_containers_cli/cmds/argo_commands.py 88.46% 3 Missing ⚠️
src/edge_containers_cli/cmds/k8s_commands.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   82.19%   82.35%   +0.16%     
==========================================
  Files          16       16              
  Lines        1022     1020       -2     
==========================================
  Hits          840      840              
+ Misses        182      180       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilesknap
Copy link
Member

I am seeing an issue with this version and P47.

  • use p47-deployment
  • restart all services in sequence from top to bottom
    • this looked like it worked
  • stop all services in sequence from top to bottom
  • two of the services remain busy and can't be changed
  • looking at argocd, it does not agree with the ready column shown by monitor, in fact all of the services appear to be running
    image

@gilesknap
Copy link
Member

@marcelldls we have agreed that these separate problems will be fixed in a later PR:

  • ArgoCD can't handle multiple simultaneous commands
  • an unhandled exception in a handler thread breaks monitor

@gilesknap gilesknap merged commit 13ea319 into main Nov 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants