Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-risk Lens v2 name resolution changes #393

Closed
saulmc opened this issue Oct 19, 2023 · 3 comments
Closed

De-risk Lens v2 name resolution changes #393

saulmc opened this issue Oct 19, 2023 · 3 comments
Assignees
Labels
question Further information is requested queue

Comments

@saulmc
Copy link
Member

saulmc commented Oct 19, 2023

From Jason @ Airstack:

Hi XMTP gang,

We've identified a potential breaking change with Lens V2 that impacts many of our XMTP partners.
Not sure if you are aware, so posting here.

If you currently enable users to enter name.lens to message someone, or to lookup somewith with name.lens...

With Lens V2 (breaking changes, October 30) Lens will no longer be supporting handle.lens as the handle
Instead, users will belong to a namespace (e.g. Lens) and have an @handle

Lens will present thisin their APIs as lens/@handle e.g. "lens/@bradorbradley" and in the future there could be other namespaces, e.g. nintendo/@bradorbradley

If you are currently pinging the Lens API to fetch the user's 0x address from their name.lens handle, that will not be supported in that format in Lens V2.
And new users will not have a .lens at all, so you may want to think about changing the "enter name.lens" prompts with something else, like enter lens:@name or lens/@name

FYI: Airstack is going to enable our users to continue entering any of:
lens/@bradorbradley, or bradorbradley.lens, lens_id:100275, lens_id:0x024
(we'll maintain a resolver from the old format to new format)

If you want any help with this feel free to reach out

For Inbox Web and Lenster:

  1. What, if anything, is urgently required to be ready for this change?
  2. What should we eventually do but defer until once it becomes a problem?

Tasks

Preview Give feedback
No tasks being tracked yet.
@saulmc saulmc added the question Further information is requested label Oct 19, 2023
@saulmc
Copy link
Member Author

saulmc commented Oct 24, 2023

@daria-github Looks like we are 6 days away from this deadline. Is there anything we need to do to prepare?

@daria-github
Copy link
Contributor

Thanks for checking @saulmc! No, looks like Hey has a PR ready for this already, and this won't change any behavior on xmtp.chat since we weren't hitting their endpoint directly. Closing ticket.

@saulmc
Copy link
Member Author

saulmc commented Oct 24, 2023

Great news, thanks so much @daria-github !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested queue
Projects
None yet
Development

No branches or pull requests

2 participants