Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: There will be a mistake when typing a ENS subdomain name with the 'eth' in its inception of 2ld #388

Closed
hibbb opened this issue Oct 11, 2023 · 1 comment

Comments

@hibbb
Copy link

hibbb commented Oct 11, 2023

name: Report a bug
description: Report a bug to share an issue you're experiencing.
title: "Bug: There will be a mistake when typing a ENS subdomain name with the 'eth' in its beginning of 2ld"
labels: bug
body:

  • type: textarea
    id: bug-description
    attributes:
    label: Describe the bug
    description: When targeting to type a ENS subname with ". eth" in its beginning of 2ld such as "chat.etherscan. eth" into the TO field on https://xmtp.chat/, the page always shows the address of "chat. eth" instead before finishing typing. I think the script behind the page was detecting the input action until the string ". eth" found, then the page started to resolve the name "chat. eth" instead accepting the user's subsequent input, as a result, the subname like "chat.etherscan. eth" would never be resolved. Here is the screenshot: https://github.com/xmtp-labs/xmtp-inbox-web/assets/233410/e18ec4e2-81c2-47c9-a236-8d9151189ff4
  • type: textarea
    id: reproduce
    attributes:
    label: Steps to reproduce the bug
    description: In any browser, we can type such as "chat.etherscan.eth" into the TO field on https://xmtp.chat/ to reproduce the bug.
@rygine
Copy link
Contributor

rygine commented Oct 11, 2023

@hibbb thanks for taking the time to report this!

there's no simple way to solve for both chat.eth and chat.etherscan.eth as chat.eth will always be picked up first.

there are 2 workarounds for this:

  1. type faster (API calls are debounced)
  2. paste in the ETH name directly

hope this helps!

i'm going to close this issue, but if you have a way to solve this please re-open the issue along with a PR. happy to discuss further!

@rygine rygine closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants