Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something was missed in Industry drop-down list #191

Open
zlidzen opened this issue Jan 5, 2024 · 2 comments
Open

Something was missed in Industry drop-down list #191

zlidzen opened this issue Jan 5, 2024 · 2 comments

Comments

@zlidzen
Copy link

zlidzen commented Jan 5, 2024

Hello,
I examine https://opensourceindex.io/

What I did:
-Click Industry menu filter
-Uncheck "select all"
-Scroll down
-Check empty line between lines "Healthcare & Pharma" and "Public Sector"

What I got:
-Line for FARFETCH organization.

What I expect:
-I don't have empty lines inside Industry drop-down menu filter

I check - osci/preprocess/match_company/company_domain_match_list.yaml
I assume that industry field was missed for FARFETCH company

Possible solutions:

  1. Add industry field for FARFETCH with value: "Retail & Hospitality" or "Other"
  2. Add rules fields in yaml file. Example: "we have set of mandatory fields, this fields cannot be empty"

Thanks.
empty_line1

@cm-howard
Copy link
Collaborator

Thanks for the details on this one @zlidzen and for raising the PR (#192)

I've got @vlad-isayko tagged to review so we can hopefully merge soon.

@pnatashap
Copy link

Looks like autochecker is needed for this file to make it accurate all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants