Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: unenforced / test-only limits #218

Open
dweitzman opened this issue Feb 2, 2021 · 4 comments
Open

Feature request: unenforced / test-only limits #218

dweitzman opened this issue Feb 2, 2021 · 4 comments

Comments

@dweitzman
Copy link
Contributor

dweitzman commented Feb 2, 2021

Would be used as a precaution against being accidentally overly-aggressive when setting new rate limits on existing systems.

It'd probably be useful if both real and check-only limits could co-exist for the same rate limit pattern, to help with testing whether it would be safe to lower an existing rate limit.

I'm imagining something like check_only_requests_per_unit or test_requests_per_unit that could be set side-by-side with or in place of requests_per_unit and increment a different metric name instead of the existing over-limit metric (and near-limit metric) when it would have triggered.

@mattklein123
Copy link
Member

Yeah I agree this would be a nice feature to have.

@repl-david-winiarski
Copy link
Contributor

We added shadow mode functionality to our fork as a way of handling this situation replicon#12

@jespersoderlund
Copy link
Contributor

@repl-david-winiarski This is exactly what we're looking for! Is there a reason for not merging your changes upstream? I think it would be very valuable

@jespersoderlund
Copy link
Contributor

@repl-david-winiarski PR (#294 ) for shadow-mode is now merged which would have a similar effect to what you are after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants