Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: adds support for dynamically configurable credential #36217

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Sep 19, 2024

Commit Message: aws: adds support for dynamically configurable credential
Additional Description:
This adds a new API for AWS Signing filter that allows control planes to
configure the credentials providers to sign requests.

Note that the similar configuration had already been added for AWS Lambda filter,
and this adds the similar but more generic configuration API for credential in the common
configuration. In the future, the lambda filter can also leverage this new common
configuration.

Closes #36109

Risk Level: low
Testing: unit
Docs Changes: done
Release Notes: TODO after API approval
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36217 was opened by mathetake.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36217 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

@suniltheta @nbaws could you take a look and check if the direction looks good? thanks!

@nbaws
Copy link
Contributor

nbaws commented Sep 19, 2024

@mathetake ack - will provide feedback shortly

@nbaws
Copy link
Contributor

nbaws commented Sep 20, 2024

@mathetake I am ok with this design - I assume the behaviour is for this xds configuration to take precedence over the default handling?

This may also be something that rolls up capability from #34121 in future? Though I haven't looked hard at how the xds configuration ends up looking.

Can you look to update https://github.com/envoyproxy/envoy/blob/main/docs/root/configuration/http/http_filters/_include/aws_credentials.rst as. part of this PR

@mathetake
Copy link
Member Author

@nbaws thanks for the look - will get back to this PR and continue working by the end of this week

@mathetake
Copy link
Member Author

This may also be something that rolls up capability from #34121 in future? Though I haven't looked hard at how the xds configuration ends up looking.

Oh yeah I think the API here could be used to generalize and obviate the explicit config in #34121

Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake marked this pull request as ready for review October 2, 2024 04:44
@mathetake
Copy link
Member Author

@nbaws just marked the PR as ready for review now - PTAL

@alyssawilk
Copy link
Contributor

@wbpcode looks like this is ready for a pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws signing filter: allows dynamic configuration of credentials
4 participants