Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with custom siteUrl value #56

Open
daltonrooney opened this issue Nov 14, 2023 · 0 comments
Open

Problem with custom siteUrl value #56

daltonrooney opened this issue Nov 14, 2023 · 0 comments

Comments

@daltonrooney
Copy link

daltonrooney commented Nov 14, 2023

In a58625d you added the ability to set a callback custom base URL for the callback, thanks! But I'm having a problem, my custom siteUrl value is not being used, and an extra slash is being added to my callback URL.

Incorrect callback URL + extra slash
OAuth application redirect_uri mismatch

(It looks like the extra slash is always there, whether the custom siteUrl is set or not)

I believe the problem is here: https://github.com/enupal/socializer/blob/f3e8e2cfd6b34010cc9738a8a78719917785da8d/src/services/Settings.php#L65C28-L65C49

If UrlHelper::isProtocolRelativeUrl($settingsBaseUrl) returns false, $settingsBaseUrl is never applied.

I even tried setting my $siteUrl value as a relative protocol, and got an error "Hybridauth\Exception\InvalidArgumentException: A valid callback url is required."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant