You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before raising this feature request, I have made sure:
It does not lead to duplication.
It has not already been requested.
Is your feature request related to a problem? Please describe.
Issues to be resolved:
src/openqaoa-core/optimizers/qaoa_optimizer.py - (Renaming to something like vqa_optimizer.py since the functions in this module are not specific to QAOA.)
src/openqaoa-core/optimizers/training_vqa.py - (training is more meant for ML. optimization_vqa is more accurate. optimization_loop is also proposed as a module name.)
src/openqaoa-core/algorithms/baseworkflow.py - (Find a new name for the Workflow ABC. Workflow is a legacy name.)
The object WorkflowProperties in src/openqaoa-core/algorithms/baseworkflow.py, is labelled as parameters in the asdict method of the workflow objects. A proposal was made to change the entry that contains information from this class from ['data']['input_parameters'] to ['data']['input_properties'].
Describe the solution you'd like
To discuss on what is a better naming scheme for the following files.
Additional context
Issue raised to resolve conversations in ongoing PR #170 that needs to be merged
The text was updated successfully, but these errors were encountered:
Prerequisites
Before raising this feature request, I have made sure:
Is your feature request related to a problem? Please describe.
Issues to be resolved:
vqa_optimizer.py
since the functions in this module are not specific to QAOA.)training
is more meant for ML.optimization_vqa
is more accurate.optimization_loop
is also proposed as a module name.)Workflow
ABC. Workflow is a legacy name.)WorkflowProperties
in src/openqaoa-core/algorithms/baseworkflow.py, is labelled asparameters
in the asdict method of the workflow objects. A proposal was made to change the entry that contains information from this class from['data']['input_parameters']
to['data']['input_properties']
.Describe the solution you'd like
To discuss on what is a better naming scheme for the following files.
Additional context
Issue raised to resolve conversations in ongoing PR #170 that needs to be merged
The text was updated successfully, but these errors were encountered: