Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming certain files and classes #182

Open
2 tasks done
shahidee44 opened this issue Feb 16, 2023 · 1 comment
Open
2 tasks done

Renaming certain files and classes #182

shahidee44 opened this issue Feb 16, 2023 · 1 comment
Assignees

Comments

@shahidee44
Copy link
Collaborator

Prerequisites

Before raising this feature request, I have made sure:

  • It does not lead to duplication.
  • It has not already been requested.

Is your feature request related to a problem? Please describe.

Issues to be resolved:

  1. src/openqaoa-core/optimizers/qaoa_optimizer.py - (Renaming to something like vqa_optimizer.py since the functions in this module are not specific to QAOA.)
  2. src/openqaoa-core/optimizers/training_vqa.py - (training is more meant for ML. optimization_vqa is more accurate. optimization_loop is also proposed as a module name.)
  3. src/openqaoa-core/algorithms/baseworkflow.py - (Find a new name for the Workflow ABC. Workflow is a legacy name.)
  4. The object WorkflowProperties in src/openqaoa-core/algorithms/baseworkflow.py, is labelled as parameters in the asdict method of the workflow objects. A proposal was made to change the entry that contains information from this class from ['data']['input_parameters'] to ['data']['input_properties'].

Describe the solution you'd like

To discuss on what is a better naming scheme for the following files.

Additional context

Issue raised to resolve conversations in ongoing PR #170 that needs to be merged

@Q-lds
Copy link
Member

Q-lds commented Mar 15, 2023

@shahidee44 has this been done? You may also rename the issue with a more explicative name!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants