Remove PySide as a test dependency #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a bit premature: tests pass, but some of those tests are being skipped. See #1792 for a fix. |
flongford
approved these changes
May 7, 2024
Comment on lines
-23
to
-35
| - name: Install Linux packages for Qt support | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install libegl1 | ||
| sudo apt-get install libxkbcommon-x11-0 | ||
| sudo apt-get install libxcb-cursor0 | ||
| sudo apt-get install libxcb-icccm4 | ||
| sudo apt-get install libxcb-image0 | ||
| sudo apt-get install libxcb-keysyms1 | ||
| sudo apt-get install libxcb-randr0 | ||
| sudo apt-get install libxcb-render-util0 | ||
| sudo apt-get install libxcb-shape0 | ||
| if: matrix.os == 'ubuntu-latest' |
There was a problem hiding this comment.
Very nice tidy up! One less place to remember all the X11 packages...
| if: matrix.os != 'ubuntu-latest' | ||
| - name: Test Traits package | ||
| run: python -m unittest discover -v traits | ||
| working-directory: testdir |
There was a problem hiding this comment.
Huh, TIL working-directory context in GH Actions.
Quite handy indeed.
|
Thanks for review, @flongford! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1788 and #1792, we should no longer need a working Qt backend when testing. Accordingly, this PR:
apt-getQt packages on Ubuntu runnersxvfb-runon Ubuntu runners