1.7.x Compatibility?

[dave-fl]

Will this work with 1.7.x? Getting a bunch of warnings during DLL compilation process.

[dpinte]

@david-wolf it should work fine as 1.7 did not had major changes. If you can repot specific warnings or errors, that would help.

[dave-fl]

FAILED (failures=4, errors=1, skipped=1)

test_results.txt

[dave-fl]

Fixed the error in the test case. Warnings but it passed. Would like to know reason for the failures.

test_results.txt

[dpinte]

I'll look into the details. From a quick review, can you confirm you build the QL DLL as explained in the doc? In particular the point 1 in this section https://github.com/enthought/pyql/blob/master/docs/source/getting_started.rst#installation-from-source-on-windows

[dave-fl]

Yes I did. Those steps seem to guarantee that if followed correctly the program will run - not its program correctness.

I had some issues initially with the DEF file which prevented compilation but I went back and fixed that.

[dave-fl]

Note I used QL 1.7.1, MSVC 14 and Anaconda latest version with Python 3.5.

Those settings have some issues too. First you are not updating a settings.py file you are updating a C++ file. Second you require Cygwin to be installed specifically with NM which is part of binutils.

[dave-fl]

Full build output.
build_output.txt

[dpinte]

Thanks @dave-fl for the report. I'll investigate asap.

[bigtan]

build_output.txt

I got the similar output as @dave-fl, But I failed the comiling. The error log is listed in the txt file.

I used the nm from the mingw, maybe this is the reason, or should I try cygwin?

[dpinte]

I think we should investigate the https://github.com/enthought/pyql/blob/master/scripts/generate_symbols.py and check if it does its job correctly. It has been designed on Python 2.7 and known to work with Python 3.3. Python 3.5. is using a new Visual Studio version that might do things in a different way ...

[dave-fl]

I used cygwin. Took a while to get the build going and then we had failed unit test cases.

[bigtan]

Hi @dpinte I use Python27 and vs2015, the .def file generated is just about 15mb. So I agree with you, Maybe something wrong with https://github.com/enthought/pyql/blob/master/scripts/generate_symbols.py

[ceaza]

Hi @bigtan , it may be something to do with fact that Python27 is compiled using vs2008, and you are using vs2015. I can compile PyQl on WinPython3.5 but not on Python2.7 and I think this was my 2.7 issue. See [https://blog.ionelmc.ro/2014/12/21/compiling-python-extensions-on-windows/].

So while I don't have much experience in this, all downstream modules would also need to be compiled in vs2008.

[bigtan]

@ceaza I will try it on my laptop, and give the feedback here.

[dpinte]

@bigtan I confirme what @ceaza says. You must use the compatible MSVC version for the target Python. Python 2.7 means MSVC 2008.

[dpinte]

@bigtan another comment: it is expected that the def file is a big file...

[bigtan]

@dpinte I have finished the compiling for python 35 with MSVC2015, it works well.
I am now trying to compiling it for python 27 with MSVC2008

[dave-fl]

Is this active at all?

[dpinte]

@dave-fl I don't have much bandwidth at the moment. If you have some pressing needs and want to consider other options than contributor's free time, ping me by e-mail.