Parser TS bindings #7881
Merged
Parser TS bindings #7881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
MichaelMauderer,
mwu-tow and
farmaazon
as code owners
farmaazon
approved these changes
Oct 11, 2023
Frizi
approved these changes
Oct 11, 2023
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
Removes dependencies that should not be in the root `package.json` Basic testing done with `npm run ci-check`. Introduced by the following PRs (in order of being merged): See blame for more details: https://github.com/enso-org/enso/blame/develop/package.json - #7813 - #7656 (oops) - #7881 # Important Notes None
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
- Validate spans during existing lexer and parser unit tests, and in `enso_parser_debug`. - Fix lost span info causing failures of updated tests. # Important Notes - [x] Output of `parse_all_enso_files.sh` is unchanged since before #7881 (modulo libs changes since then). - When the parser encounters an input with the first line indented, it now creates a sub-block for lines at than indent level, and emits a syntax error (every indented block must have a parent). - When the parser encounters a number with a base but no digits (e.g. `0x`), it now emits a `Number` with `None` in the digits field rather than a 0-length digits token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Generate TS bindings and lazy deserialization for the parser types.
Important Notes
ffi.ts, but not yet used.vitest.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.