Add Decimal type to Enso

[jdunkerley]

Basic Decimal type with a BigDecimal backing field inside.

• Arithmetic, Constructors, Comparisons (Decimal type: constuctors, comparisons, and arithmetic #9272)
• Sign methods (abs, negate, signum)
• Min / max
• Rounding
• Conversions
• BigDecimal-specific (scale, precision, etc)

Original task:

• Needs to support scale.

Following operators should work: +, -, /, *, %,
Additionally, they should support all the comparison operations in usual way.

Auto convert from Integer to Decimal is allowed.
Float to decimal needs to be called explicity via (Decimal.from_float and possibly Float.to_decimal self attach a precision warning).

Will be issue with == where left side is an Integer.

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-09):

Progress: Reading BigDecimal docs and implementation; experimented with scale; basic Enso wrapper, addition It should be finished by 2024-02-19.

Next Day: aritchmetic

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-13):

Progress: Enabled empty-table tests for Table.replace in the DB backend; Implemented constructors from int, float, string; implemented precision and rounding It should be finished by 2024-02-19.

Next Day: some more experiments, then arithmetic

[enso-bot]

Greg Travis reports a new STANDUP for the provided date (2024-02-12):

Progress: reviews for Table.replace and wrapping error; Handling more edge cases in Table.replace (empty lookup table); diving into comparables, hashing, comparisons, bigdecimal precision/scale It should be finished by 2024-02-19.

Next Day: some more experiments, then arithmetic

[enso-bot]

Greg Travis reports a new STANDUP for yesterday (2024-02-14):

Progress: Table.replace review; Decimal.from_float; report precision loss when Math_Context is explicitly used; implemented precision loss report for floats without Math_Context but then realize that’s not possible; implemented Java_Problems-based approach before realizing that’s Table-specific It should be finished by 2024-02-19.

Next Day: finish constructors, tests for precision loss warning

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-15):

Progress: finished ctors + precision checking, implemented == both ways, tests It should be finished by 2024-02-19.

Next Day: == including bd-specific issues

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-16):

Progress: Implemented equality and other comparisons using Jarsolav's branch; tests It should be finished by 2024-02-19.

Next Day: arithmetic

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-19):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Representation issues

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-19):

Progress: upgraded graalvm; started on arithmetic; ran into a problem with hash/equals inconsistency It should be finished by 2024-02-20.

Next Day: more arithmetic

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-26):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-26):

Summary: There is 6 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-26):

Progress: hash consistency It should be finished by 2024-02-27.

Next Day: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for the provided date (2024-02-20):

Progress: Reading HashCodeNode and EqualsNode; experimenting with a Decimal hash that is consistent with those; working on failing examples. It should be finished by 2024-02-27.

Next Day: get hashing working

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-27):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-27):

Progress: Tracking down a problem when passing Floats to std-bits Java; more work on comparator + hashing It should be finished by 2024-02-28.

Next Day: hash consistency

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-28):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-28):

Progress: Got a consistent hash, but thinking about speed and will do some benchmarking. It should be finished by 2024-02-29.

Next Day: hash consistency + speed

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-02-29):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-02-29):

Progress: fixed test failures in DB replace. Hunted down is_nan bug. Wrote tests verifying (or not) equality/hash consistency. equality consistency failures It should be finished by 2024-03-01.

Next Day: hash consistency + speed

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-01):

Summary: There is 3 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-01):

Progress: ==/hash consistency for all values but one (!); handling values around +/- max double, min double It should be finished by 2024-03-04.

Next Day: arithmentic

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-04):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-04):

Progress: Got decimal inequalities and tests working except for <=, >=. Started on arithmetic. It should be finished by 2024-03-05.

Next Day: arithmentic

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-05):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: hash consistency

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-05):

Progress: completed arithmetic, with docs & tests; tests for precision settings + errors; tests for mixed arithmetic; attaching loss-of-precision warnings; tracked down bug with incomparable internal representations of Decimal + created a test; tracked down bug when returning a small BigInteger from std-bits code, and added workaround; include Jaroslav’s fix for le/ge It should be finished by 2024-03-06.

Next Day: arithmentic

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-06):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-27):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-27):

Progress: div, mod, pow It should be finished by 2024-03-28.

Next Day: benchmarking

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-28):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-28):

Progress: benchmarking It should be finished by 2024-03-29.

Next Day: benchmarking

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-03-29):

Summary: There is 3 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-03-29):

Progress: benchmarking It should be finished by 2024-04-01.

Next Day: dataflow stack trace control; more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-01):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-01):

Progress: Decimal hashing consistency and discussion; Decimal % consistency It should be finished by 2024-04-02.

Next Day: dataflow error traces?

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-02):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-02):

Progress: various decimal review stuff; engine stack trace context It should be finished by 2024-04-03.

Next Day: engine stack trace context

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-03):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-03):

Progress: implemented dataflow error stack trace control for enso-origin errors It should be finished by 2024-04-04.

Next Day: engine stack trace context

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-04):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-04):

Progress: Researched implementation of java-origin dataflow error stack trace control -- fix State threading (#7117) or explicitly pass State in all nodes that return a dataflow error; Started on Decimal format/parse It should be finished by 2024-04-05.

Next Day: format/parse

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-05):

Summary: There is 3 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-05):

Progress: unit test errors for dataflow error change; Decimal parse/float + tests It should be finished by 2024-04-08.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-08):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-08):

Progress: Working on attaching warnings on integer conversion, but wrestling again with possibly a decimal / integer comparison problem It should be finished by 2024-04-09.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-09):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-09):

Progress: working on decimal/integer comparison problems again; integrated Jaroslav’s fix
decimal methods; working on rounding, which is of course complicated It should be finished by 2024-04-10.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-10):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-10):

Progress: reviews for several Decimal PRs; try to run frontend, debug java exe path It should be finished by 2024-04-11.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-11):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-11):

Progress: Decimal PRs; fixing front-end macos path It should be finished by 2024-04-12.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-12):

Summary: There is 3 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-12):

Progress: run ide; decimal truncate, ceil, floor It should be finished by 2024-04-15.

Next Day: more decimal methods

[enso-bot]

Greg Travis reports a new 🔴 DELAY for today (2024-04-15):

Summary: There is 1 days delay in implementation of the Add Decimal type to Enso (#8982) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it's a big task

[enso-bot]

Greg Travis reports a new STANDUP for today (2024-04-15):

Progress: Fixing unit tests for DataflowError stack trace context It should be finished by 2024-04-16.

Next Day: more decimal methods