Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info on exif-data for personal photos #29

Open
acidicX opened this issue Feb 14, 2021 · 2 comments
Open

Info on exif-data for personal photos #29

acidicX opened this issue Feb 14, 2021 · 2 comments

Comments

@acidicX
Copy link

acidicX commented Feb 14, 2021

Hi,

first of all, thanks for creating the addon!
I've read the source but haven't found any info on how you parse the exif-data (note: I'm not that good in python), although it is mentioned in the README.

Which library is used and which properties does the addon parse and how should it be displayed? It would be nice if you could include that in the README, bceause there are a lot of similar-sounding fields in exif and XMP data.

Thanks!

@fuse314
Copy link
Contributor

fuse314 commented Sep 21, 2021

For the personal photos, there is no parsing of EXIF or XMP data.
Only the information provided in the "images.json" file is loaded and displayed (if present in the root of the selected folder).
screensaverutils.py:L49
You will have to create your own parser for the EXIF or XMP data and put this information in the two available lines of "images.json"
Example images.json:

[
 {
  "image":"IMG_0001.jpg",
  "line1":"Line 1 for 0001",
  "line2":"Line 2 for 0001"
 },
 {
  "image":"IMG_0002.jpg",
  "line1":"Line 1 for 0002",
  "line2":"Line 2 for 0002"
 }
]

I hope this helps.

There is currently a bug that keeps displaying "line2" from the previous picture, if the current picture does not have a "line2" set, it will be fixed if/when pull request 28 is merged.

@acidicX
Copy link
Author

acidicX commented Sep 22, 2021

@fuse314 thanks for the explanation! I've written a few lines in TypeScript to parse my Exif data and write that into the JSON. Works like a charm!

I'd open a PR to clarify this in the README if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants