Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both playback and offline download of some targets fail when HEVC is not enabled #49

Open
graysky2 opened this issue Apr 29, 2021 · 1 comment · Fixed by #51
Open

Both playback and offline download of some targets fail when HEVC is not enabled #49

graysky2 opened this issue Apr 29, 2021 · 1 comment · Fixed by #51

Comments

@graysky2
Copy link
Contributor

graysky2 commented Apr 29, 2021

Attempting to "Download Videos" for the following targets results in an error and failure to download:

  • All
  • California to Vegas
  • Hong Kong

On the "Aerial Screensavers" tab I have:

Show start notification [ X ]
Show preview windows [ ]
Enable 4K (default 1080p) [ ]
Enable HDR [ ]
Enable HEVC (required for 4K/HDR) [ ]

Kodi.log when attempting to download from the "All" target is below. Similar output when using the other two targets.

2021-04-29 06:11:40.006 T:153130   ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'TypeError'>
                                                   Error Contents: argument of type 'NoneType' is not iterable
                                                   Traceback (most recent call last):
                                                     File "/usr/share/kodi/addons/screensaver.atv4/entrypointscript.py", line 13, in <module>
                                                       atv.run(len(sys.argv) > 1)
                                                     File "/usr/share/kodi/addons/screensaver.atv4/resources/lib/atv.py", line 163, in run
                                                       offline()
                                                     File "/usr/share/kodi/addons/screensaver.atv4/resources/lib/offline.py", line 64, in offline
                                                       if "https" in url:
                                                   TypeError: argument of type 'NoneType' is not iterable
                                                   -->End of Python script error report<--
                                                   
2021-04-29 06:11:40.028 T:153130    INFO <general>: Python interpreter stopped

Further, the addon will not play a single video unless I enable "Enable HEVC (required for 4K/HDR)"

@graysky2 graysky2 changed the title Offline download of some targets fail when HEVC is not enabled Both playback and offline download of some targets fail when HEVC is not enabled Apr 29, 2021
@kubedzero
Copy link
Contributor

This should be able to be closed, as it is fixed by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants