diff --git a/.github/workflows/lockdown-canary.yml b/.github/workflows/lockdown-canary.yml index a3ec5abe1d..04f35e7eeb 100644 --- a/.github/workflows/lockdown-canary.yml +++ b/.github/workflows/lockdown-canary.yml @@ -21,6 +21,7 @@ jobs: - name: Setup Chrome uses: browser-actions/setup-chrome@latest + ## location is OS dependent with: chrome-version: 'canary' @@ -31,5 +32,5 @@ jobs: - name: Run tests run: | - echo "$(which google-chrome-unstable)" "$(which google-chrome)" - node ./packages/ses/smoke-test/index.js "$(which google-chrome-unstable)" \ No newline at end of file + echo "$(which chrome)" "$(which google-chrome-unstable)" "$(which google-chrome)" + node ./packages/ses/smoke-test/index.js "$(which chrome)" \ No newline at end of file diff --git a/packages/ses/smoke-test/index.js b/packages/ses/smoke-test/index.js index 05e712ed89..8ad196a095 100644 --- a/packages/ses/smoke-test/index.js +++ b/packages/ses/smoke-test/index.js @@ -1,8 +1,11 @@ /* eslint-disable @endo/no-polymorphic-call */ +/* global process */ + import puppeteer from 'puppeteer-core'; import assert from 'assert'; const chromePath = process.argv[2]; +console.log(`chromePath ${chromePath}`); let browser; @@ -43,6 +46,6 @@ async function runTests() { runTests().catch(error => { console.error(error); - browser.close(); + browser&& browser.close(); process.exit(1); });