From 4712bb7971082ec460e9db6496eed3c8cbb803f7 Mon Sep 17 00:00:00 2001 From: Kris Kowal Date: Wed, 13 Mar 2024 14:49:54 -0700 Subject: [PATCH 1/2] chore: Drop Node.js 16 from CI entirely --- .github/workflows/ci.yml | 6 +++--- .github/workflows/depcheck.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e26b62542..42ed816a46 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -119,9 +119,9 @@ jobs: fail-fast: false matrix: node-version: - - '16.1' # last version before some significant promise hooks changes - - '16.5' # last version before unconditional promise fast-path - - '16.6' # first version after unconditional promise fast-path + # - '16.1' # last version before some significant promise hooks changes + # - '16.5' # last version before unconditional promise fast-path + # - '16.6' # first version after unconditional promise fast-path - '18' # Active LTS # '20.6' not viable due to https://github.com/nodejs/node/issues/49497 # '20.3' to '20.6' not viable due to https://github.com/nodejs/node/pull/49211 diff --git a/.github/workflows/depcheck.yml b/.github/workflows/depcheck.yml index 2994564775..dbda0fa11d 100644 --- a/.github/workflows/depcheck.yml +++ b/.github/workflows/depcheck.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ['16.x'] + node-version: ['18.x'] steps: - uses: actions/checkout@v3 with: From 03803576bd074669088a7be556a4a2a6488210c6 Mon Sep 17 00:00:00 2001 From: Kris Kowal Date: Wed, 13 Mar 2024 16:52:11 -0700 Subject: [PATCH 2/2] chore: Collapse depcheck CI matrix --- .github/workflows/depcheck.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/depcheck.yml b/.github/workflows/depcheck.yml index dbda0fa11d..df62ded370 100644 --- a/.github/workflows/depcheck.yml +++ b/.github/workflows/depcheck.yml @@ -11,16 +11,13 @@ on: jobs: build: runs-on: ubuntu-latest - strategy: - matrix: - node-version: ['18.x'] steps: - uses: actions/checkout@v3 with: submodules: 'true' - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node-version }} + node-version: 18.x - name: Install graphviz run: sudo apt install -y graphviz