Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme block dropdowns #203

Closed
manuq opened this issue Aug 22, 2024 · 1 comment · Fixed by #245
Closed

Theme block dropdowns #203

manuq opened this issue Aug 22, 2024 · 1 comment · Fixed by #245
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@manuq
Copy link
Contributor

manuq commented Aug 22, 2024

What Happened

The dropdowns look wrong, especially for the Light theme.

How to Reproduce

  1. Change Godot to Light theme in Editor Settings
  2. Open the Pong example, click Block Code for a paddle
  3. See the dropdowns in the "Move with player..." block:
    Captura desde 2024-08-22 16-24-13

Block Coding Plugin Version

main

Godot Engine Version

v4.3

Operating System

Endless OS

Logs or command-line output

No response

Anything else?

No response
@dylanmccall dylanmccall added bug Something isn't working good first issue Good for newcomers labels Aug 24, 2024
@DoomTas3r DoomTas3r mentioned this issue Oct 5, 2024
Merged
@DoomTas3r
Copy link
Contributor

Is this good?

#245 (comment)

wjt pushed a commit to DoomTas3r/changes-block-coding that referenced this issue Oct 10, 2024
@DoomTas3r @wjt
Improve dropdown styling
82073b4 
Fixes endlessm#203
wjt pushed a commit to DoomTas3r/changes-block-coding that referenced this issue Oct 10, 2024
@DoomTas3r @wjt
Improve dropdown styling
f699304 
Changes the text color and style of the dropdowns to have no mouse hover
interaction and more contrast. The dropdown popup menu is unaffected (it will
still use the editor theme)

Fixes endlessm#203
@wjt wjt closed this as completed in #245 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dropdown contrast DoomTas3r/changes-block-coding
3 participants
@manuq @dylanmccall @DoomTas3r