Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text for yellow blocks black or change yellow to something darker #202

Open
wareya opened this issue Aug 22, 2024 · 5 comments
Open
Labels
bug Something isn't working

Comments

@wareya
Copy link

wareya commented Aug 22, 2024

What Happened

The yellow blocks are really hard to read, especially on displays with poor contrast, overly bright gamma settings, or glare.

How to Reproduce

Add a yellow block and see it being hard to read the label.

Block Coding Plugin Version

No response

Godot Engine Version

No response

Operating System

No response

Logs or command-line output

No response

Anything else?

Adding a black outline or dropshadow, or making the text black with a white outline or dropshadow, might also help instead. Lots of options. It's just really hard to read text-background color combinations that have poor contrast.

@manuq
Copy link
Contributor

manuq commented Aug 22, 2024

@wareya can you share a screen capture? You are probably trying an old release. Or maybe the last release has the blocks for Pong with old colors. This won't be the case anymore in next release because now the colors are not persisted in the project anymore.

@wareya
Copy link
Author

wareya commented Aug 22, 2024

Oh, the yellow nodes are gone and it's only the light orange ones now. The light orange is a lot better than the yellow, but it's still hard to read.

image

Here's what it might look like on a monitor with bright gamma:

image

@manuq
Copy link
Contributor

manuq commented Aug 22, 2024

@wareya would you like to provide an alternative color code? I borrowed this one from the CSS of Microsoft MakeCode Arcade, but their font is bold so it looks better:
Captura desde 2024-08-22 16-40-43

@wareya
Copy link
Author

wareya commented Aug 22, 2024

e06000 seems to have enough contrast (bottom node):

image

It's starting to get into brown territory, but I think that's better than being hard to read.

I feel like doing a second pass over the colors might be a good idea in general; the light and dark green/blue look very similar to their counterparts in terms of brightness, and the magenta of "sounds" doesn't fit in with the other, more muted colors. Also the red-orange of "input" might look better with a little less orange and a little more black.

@manuq
Copy link
Contributor

manuq commented Aug 23, 2024

Thanks, that orange is much more readable.

I feel like doing a second pass over the colors might be a good idea in general; the light and dark green/blue look very similar to their counterparts in terms of brightness, and the magenta of "sounds" doesn't fit in with the other, more muted colors. Also the red-orange of "input" might look better with a little less orange and a little more black.

@wareya yes please! If you would like to give a pass over all the colors, here is where they are defined:

const BUILTIN_CATEGORIES_PROPS: Dictionary = {

@dylanmccall dylanmccall added the bug Something isn't working label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants