-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: asgiref tls extension #1842
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brussee
force-pushed
the
feature-asgiref-tls-extension
branch
2 times, most recently
from
January 10, 2023 19:20
1a61efc
to
4978775
Compare
brussee
force-pushed
the
feature-asgiref-tls-extension
branch
2 times, most recently
from
January 10, 2023 19:37
594a90c
to
88c6cc6
Compare
workaround: pass server_cert from config
brussee
force-pushed
the
feature-asgiref-tls-extension
branch
2 times, most recently
from
January 10, 2023 20:11
e5b7b75
to
e1666f5
Compare
I amended some commits to make the linter happy (almost there). I won't force-push this branch anymore after anyone has started their review. |
brussee
force-pushed
the
feature-asgiref-tls-extension
branch
3 times, most recently
from
January 10, 2023 20:33
85e2566
to
1ee3306
Compare
brussee
force-pushed
the
feature-asgiref-tls-extension
branch
from
January 10, 2023 20:41
1ee3306
to
3b17666
Compare
Closed
#1119 was rebased, should we close this? |
Progress is being made on original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fully based on: #1119 and rebased on master (23b9f05)
Added similar implementation for websockets (untested)