Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pairing, connection handling to use SHIP ID or SKI #19

Open
DerAndereAndi opened this issue Mar 21, 2024 · 4 comments
Open

Allow pairing, connection handling to use SHIP ID or SKI #19

DerAndereAndi opened this issue Mar 21, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DerAndereAndi
Copy link
Member

Instead of solely relying on the SKI, it should also be possible to use the SHIP ID to finde a remote device and initiate a connection.

SHIP Version 1.1 also recommends that (at least)

@DerAndereAndi DerAndereAndi added the enhancement New feature or request label Mar 21, 2024
@DAMEK86
Copy link

DAMEK86 commented Aug 31, 2024

tech note: I saw multiple devices using ipv4 and ipv6 or multiple ipv4 addresses for the same ship id.. with this in mind, we also should consider binding against a specific interface and hope the user configured this interface properly, otherwise it will happen, that the code likes to talk to a device over a different route without a router because of mDNS multicast address broadcasting.
Simply scan your network with avahi-browse -a -r, if you work with a ctrlbox 👍

@DerAndereAndi
Copy link
Member Author

RIght now it is already possible to limit the mDNS announcement to a specific (set of) network interface(s). See https://github.com/enbility/ship-go/blob/dev/mdns/mdns.go#L77 which is used via https://github.com/enbility/eebus-go/blob/dev/api/configuration.go#L188-L192

@DAMEK86
Copy link

DAMEK86 commented Sep 1, 2024

I saw this already, the question in terms of expectations is, if the user need some guidance or has a strong background knowledge in this area and understand why it doesn't work.

Furthermore, we currently using filters because the shipid should be unique. E.g. if you like to connect against a specific device family/supplier, a substring filter would be nice as well.

So the Acceptance criteria for this issue is just the ship as is itself or do you accept a filter pattern matching as well?

@DerAndereAndi
Copy link
Member Author

This issue is about identifying already paired devices over mDNS by looking for the SHIP ID of the paired device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants