Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement Read/Write traits for embedded_io::{Read,Write} #105

Closed
1 task done
elrafoon opened this issue Feb 16, 2024 · 2 comments
Closed
1 task done
Labels
enhancement New feature or request

Comments

@elrafoon
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Dear maintainers,

I think it would be very useful to have support for embedded_io traits right in the ciborium - implement ciborium::{Read,Write} for embedded_io::{Read,Write}.

I have already implemented it, but now I realized one problem - ciborium currently sets MSRV to 1.58.

With rust 1.58, there is no support for optional dependencies (so I can't make embedded-io optional) and also limits embedded-io version to 0.5.0 (while current is 0.6.1).

See pull request

How shall I proceed?

Acceptance Criteria

No response

Suggestions for a technical implementation

No response

@elrafoon elrafoon added the enhancement New feature or request label Feb 16, 2024
@rjzak
Copy link
Member

rjzak commented Feb 16, 2024

I have a PR open to boost the MSRV #103, and it's stuck on an unrelated unit test that fails. I can force it, but I'd appreciate help on trying to figure out the cause.

@rjzak
Copy link
Member

rjzak commented Feb 17, 2024

Closed via #104

@rjzak rjzak closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants