[Bug]: MSRV with latest [email protected] is now on 1.70

[elpiel]

Is there an existing issue for this?

• I have searched the existing issues

Code of Conduct

• I agree to follow this project's Code of Conduct

Current Behaviour

Although MSRV is set for -ll because of the upgrade of [email protected] MSRV is now 1.70
``

Expected Behaviour

MSRV 1.58 should be respected even with optional dependency half

Environment Information

https://github.com/AeroRust/nmea/actions/runs/7723182617/job/21052735785?pr=118

Steps To Reproduce

No response

[rjzak]

We're using half v2.2, which is has a MSRV of 1.58. https://github.com/starkat99/half-rs/tree/08a03fd47b9241024e68bf375f2a7a84287bf481.

Maybe you're asking for half to be bumped, along with the MSRV?

Looking at your Cargo.toml, it seems your project is pulling in half 2.3, which is odd since our Cargo.toml specified 2.2. So maybe we need =2.2 to prevent the compiler from picking a newer version. But just updating dependencies is probably better :)

[elpiel]

Yes, what specifying "2.2" means is "^2.2" which means that minor versions are upgraded (i.e. to 2.3).
As for my Cargo.toml, I don't actually depend on ciborium but criterion and I had to split the criterion benchmark to separate crate to avoid bumping MSRV every time a dependency of criterion bumps it.

[rjzak]

Closed via #103