Fix name clashes in FAT filesystem (#614)

emuflight · Jun 21, 2021 · dd91486 · dd91486
1 parent febd629
commit dd91486
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/main/io/asyncfatfs/asyncfatfs.c b/src/main/io/asyncfatfs/asyncfatfs.c
@@ -2255,8 +2255,18 @@ static void afatfs_createFileContinue(afatfsFile_t *file) {
                         opState->phase = AFATFS_CREATEFILE_PHASE_FAILURE;
                         goto doMore;
                     }
+                } else if (entry->attrib & FAT_FILE_ATTRIBUTE_VOLUME_ID) {
+                    break;
                 } else if (strncmp(entry->filename, (char*) opState->filename, FAT_FILENAME_LENGTH) == 0) {
-                    // We found a file with this name!
+                    // We found a file or directory with this name!
+
+                    // Do not open file as dir or dir as file
+                    if (((entry->attrib ^ file->attrib) & FAT_FILE_ATTRIBUTE_DIRECTORY) != 0) {
+                        afatfs_findLast(&afatfs.currentDirectory);
+                        opState->phase = AFATFS_CREATEFILE_PHASE_FAILURE;
+                        goto doMore;
+                    }
+
                     afatfs_fileLoadDirectoryEntry(file, entry);
                     afatfs_findLast(&afatfs.currentDirectory);
                     opState->phase = AFATFS_CREATEFILE_PHASE_SUCCESS;