Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

update port to newer FreeType #4

Open
ericoporto opened this issue Apr 23, 2021 · 6 comments
Open

update port to newer FreeType #4

ericoporto opened this issue Apr 23, 2021 · 6 comments

Comments

@ericoporto
Copy link

ericoporto commented Apr 23, 2021

FreeType has been changing a lot from this version: https://gitlab.freedesktop.org/freetype/freetype

It would be good to either update the version here or get upstream to care about Emscripten, otherwise apps that follow upstream will start to break with this version.

I opened a somewhat similar issue on FreeType repository - FreeType has a really complex codebase I can't seem to make progress understanding it, so while I need it, I can't help much.
https://gitlab.freedesktop.org/freetype/freetype/-/issues/1052

@ericoporto
Copy link
Author

ericoporto commented May 4, 2021

I discovered that the latest FreeType builds fine using emcmake cmake with their latest CMakeLists.txt file, so I switched to using that in my workflow. It would be nice to update the port though so it doesn't cause troubles for people finding it.

@kripken
Copy link
Member

kripken commented May 5, 2021

I agree it would be good to update the port. That would also run it through the emscripten test suite, which has a few regression tests for freetype. If those all pass we should be ok.

@HCLJason
Copy link

I have a PR for this, as well as a matching tools/ports/freetype.py update almost ready to go for the emscripten-core/emscripten repo.

I did have trouble compiling it if we named the release anything but version_1. When I checked for a hard-coded version_1, grep turned up empty.

We need to merge the PR, create a new release, then add the sha512 into the tools/ports/freetype.py file.

@ericoporto
Copy link
Author

ericoporto commented Jul 1, 2021

This is a different project doing different things, but the list of files for building FreeType on Emscripten ports when using 2.10.4 is probably similar to the list I have here: ericoporto/ags@70b3435 or here: Makefile-defs.freetype., attention too to the macro FT2_BUILD_LIBRARY.

@albertvaka
Copy link

This might also (maybe) be the fix for #3

@HinTak
Copy link

HinTak commented Oct 11, 2022

@albertvaka the color font issue is likely not version related but libpng related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants