From 1097c0d1b9dd63f9573812b9ddb41b790725b46e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20CG?= <victorcg88@users.noreply.github.com>
Date: Wed, 10 Jul 2024 18:46:15 +0200
Subject: [PATCH] feat(create-animation): migrate to composition API (#1553)

Co-authored-by: Jose A. Cabaneros <joseacabaneros@gmail.com>
Co-authored-by: Diego Pascual <diegopf@users.noreply.github.com>
---
 .../src/components/animations/index.ts        |  1 +
 .../animations/test-animation-factory.vue     | 99 +++++++++++++++++++
 packages/_vue3-migration-test/src/router.ts   |  6 ++
 .../create-directional-animation-factory.ts   | 54 +++++-----
 4 files changed, 132 insertions(+), 28 deletions(-)
 create mode 100644 packages/_vue3-migration-test/src/components/animations/test-animation-factory.vue

diff --git a/packages/_vue3-migration-test/src/components/animations/index.ts b/packages/_vue3-migration-test/src/components/animations/index.ts
index f1ee0800dd..b951da74a4 100644
--- a/packages/_vue3-migration-test/src/components/animations/index.ts
+++ b/packages/_vue3-migration-test/src/components/animations/index.ts
@@ -4,3 +4,4 @@ export { default as TestCollapseWidth } from './test-collapse-width.vue';
 export { default as TestCrossFade } from './test-cross-fade.vue';
 export { default as TestFade } from './test-fade.vue';
 export { default as TestFadeAndSlide } from './test-fade-and-slide.vue';
+export { default as TestAnimationFactory } from './test-animation-factory.vue';
diff --git a/packages/_vue3-migration-test/src/components/animations/test-animation-factory.vue b/packages/_vue3-migration-test/src/components/animations/test-animation-factory.vue
new file mode 100644
index 0000000000..3aa3de66cf
--- /dev/null
+++ b/packages/_vue3-migration-test/src/components/animations/test-animation-factory.vue
@@ -0,0 +1,99 @@
+<template>
+  <div class="animate-modal">
+    <p>
+      BREAKING Vue3: `h()` hyperscript doesn't support rendering `'transition'` using strings.
+      Instead, replace it by `Transition` component of Vue 3 itself `import { Transition } from
+      'vue'`.
+      <br />
+      <a href="https://github.com/vuejs/core/issues/826#issuecomment-598207464">
+        https://github.com/vuejs/core/issues/826#issuecomment-598207464
+      </a>
+      <br />
+      <a href="https://github.com/vuejs/test-utils/issues/471#issuecomment-804477181">
+        https://github.com/vuejs/test-utils/issues/471#issuecomment-804477181
+      </a>
+    </p>
+    <p>
+      BREAKING Vue3: Review Transition Class Change. Replace instances of `.v-enter` to
+      `.v-enter-from` Replace instances of `.v-leave` to `.v-leave-from`.
+      <br />
+      <a href="https://v3-migration.vuejs.org/breaking-changes/transition.html">
+        https://v3-migration.vuejs.org/breaking-changes/transition.html
+      </a>
+    </p>
+    <p>
+      BREAKING Vue3: VNodes now have a flat props structure.
+      <br />
+      <a
+        href="https://v3-migration.vuejs.org/breaking-changes/render-function-api.html#vnode-props-format"
+      >
+        https://v3-migration.vuejs.org/breaking-changes/render-function-api.html#vnode-props-format
+      </a>
+    </p>
+    <button @click="openWithClipPath">Open modal with CLIP PATH animation</button>
+    <button @click="openWithScale">Open modal with SCALE animation</button>
+    <button @click="openWithTranslate">Open modal with TRANSLATE animation</button>
+    <BaseModal
+      @click:overlay="open = false"
+      @focusin:body="open = false"
+      :open="open"
+      :animation="currentAnimation"
+      contentClass="content"
+      overlayClass="overlay"
+    >
+      <h1>Hello</h1>
+      <p>The modal is working</p>
+      <button @click="open = false">Close modal</button>
+    </BaseModal>
+  </div>
+</template>
+
+<script setup lang="ts">
+  import { ref, shallowRef } from 'vue';
+  import BaseModal from '../../../../x-components/src/components/modals/base-modal.vue';
+  import { animateClipPath } from '../../../../x-components/src/components/animations/animate-clip-path/animate-clip-path.factory';
+  import { animateScale } from '../../../../x-components/src/components/animations/animate-scale/animate-scale.factory';
+  import { animateTranslate } from '../../../../x-components/src/components/animations/animate-translate/animate-translate.factory';
+
+  const clipPathAnimation = animateClipPath('bottom');
+  const scaleAnimation = animateScale('bottom');
+  const translateAnimation = animateTranslate('bottom');
+
+  const currentAnimation = shallowRef(clipPathAnimation);
+  const open = ref(false);
+
+  /** Open modal with ClipPath animation. */
+  function openWithClipPath() {
+    currentAnimation.value = clipPathAnimation;
+    open.value = true;
+  }
+
+  /** Open modal with Scale animation. */
+  function openWithScale() {
+    currentAnimation.value = scaleAnimation;
+    open.value = true;
+  }
+
+  /** Open modal with Translate animation. */
+  function openWithTranslate() {
+    currentAnimation.value = translateAnimation;
+    open.value = true;
+  }
+</script>
+
+<style>
+  .animate-modal {
+    .content {
+      background: white;
+      margin: auto;
+      height: 300px;
+      width: 800px;
+      border: 3px solid green;
+      padding: 10px;
+    }
+
+    .overlay {
+      background-color: red;
+    }
+  }
+</style>
diff --git a/packages/_vue3-migration-test/src/router.ts b/packages/_vue3-migration-test/src/router.ts
index ff54faabee..c8a2c45f80 100644
--- a/packages/_vue3-migration-test/src/router.ts
+++ b/packages/_vue3-migration-test/src/router.ts
@@ -48,6 +48,7 @@ import {
   TestExperienceControls,
   TestTagging,
   TestRenderlessExtraParam,
+  TestAnimationFactory,
   TestIcons
 } from './';
 
@@ -292,6 +293,11 @@ const routes = [
     name: 'RenderlessExtraParam',
     component: TestRenderlessExtraParam
   },
+  {
+    path: '/animation-factory',
+    name: 'AnimationFactory',
+    component: TestAnimationFactory
+  },
   {
     path: '/icons',
     name: 'Icons',
diff --git a/packages/x-components/src/components/animations/create-directional-animation-factory.ts b/packages/x-components/src/components/animations/create-directional-animation-factory.ts
index c431a770a1..06969117ef 100644
--- a/packages/x-components/src/components/animations/create-directional-animation-factory.ts
+++ b/packages/x-components/src/components/animations/create-directional-animation-factory.ts
@@ -1,4 +1,14 @@
-import Vue, { VueConstructor } from 'vue';
+import { defineComponent, h } from 'vue';
+
+export type AnimationOrigin =
+  | 'top'
+  | 'bottom'
+  | 'top-to-bottom'
+  | 'bottom-to-top'
+  | 'left'
+  | 'right'
+  | 'left-to-right'
+  | 'right-to-left';
 
 /**
  * Abstract Factory to create animations Factory. The returned animation factory uses the
@@ -9,36 +19,24 @@ import Vue, { VueConstructor } from 'vue';
  *
  * @internal
  */
-export function createDirectionalAnimationFactory(
-  animationName: string
-): (animationOrigin?: AnimationOrigin) => VueConstructor {
-  return (animationOrigin = 'top') => {
-    return Vue.extend({
+export function createDirectionalAnimationFactory(animationName: string) {
+  return (animationOrigin: AnimationOrigin = 'top') =>
+    defineComponent({
       name: `transition-${animationName}-${animationOrigin}`,
       inheritAttrs: false,
-      render(h) {
-        return h(
-          'transition',
-          {
-            props: {
-              name: `x-${animationName}--${animationOrigin} x-${animationName}-`,
-              ...this.$attrs
+      setup(_, { attrs, listeners, slots }) {
+        return () =>
+          h(
+            'transition',
+            {
+              props: {
+                name: `x-${animationName}--${animationOrigin} x-${animationName}-`,
+                ...attrs
+              },
+              on: listeners
             },
-            on: this.$listeners
-          },
-          this.$slots.default
-        );
+            slots.default?.() ?? []
+          );
       }
     });
-  };
 }
-
-export type AnimationOrigin =
-  | 'top'
-  | 'bottom'
-  | 'top-to-bottom'
-  | 'bottom-to-top'
-  | 'left'
-  | 'right'
-  | 'left-to-right'
-  | 'right-to-left';