replacing regex to un-break groups menu on emonpi #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets see what the get statements are up to
hope the bug is here
place to put notes on potential issues/fixes that may be needed
seems that ini settings are not being honoured, why else would using the group specific feed bits result in errors like this in the log 2019-12-28 17:24:42.506|WARN|PHPFina.php|get_meta() meta file does not exist '/var/lib/phpfina/8.meta' (setting file has, phpfina[datadir] = '/var/opt/emoncms/phpfina/')
however it looks like it already does load the file, which raises even more confusion as to why it picks the wrong path 😟
|
Hello @shadowguardian507-irl Thanks a lot for this, sorry its taken me almost a year to review! This seems to be working fine. Thanks for the pointers and comments with your pull request it helped a lot to understand the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the code to use the formal php mysql string sanitisation functions and removed the broken regex expressions that were blocking successful creation and edit of groups
(group would be made but would be called null with a null description as the regex seemingly blocked all strings of any type)
I have tested this on an emonpi unit and it is working ok in regards to groups.
there are still related problems though see issue #63