Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to emmo-beta5 #680

Open
francescalb opened this issue Nov 22, 2023 · 2 comments
Open

Update to emmo-beta5 #680

francescalb opened this issue Nov 22, 2023 · 2 comments

Comments

@francescalb
Copy link
Collaborator

This is an issue that should not be taken care of before emmo-1.0.0beta5is stable.
The issue is, however, created to keep track of things that should be fixed once this is done.

@francescalb
Copy link
Collaborator Author

francescalb commented Nov 22, 2023

in tests/ontopy_tests/test_graph.py the following change is expected:

To remove:

  • emmo.ConventionalQuantitativeProperty,
  • emmo.ModelledQuantitativeProperty,

To add:

  • emmo.ConventionalProperty,
  • emmo.ModelledProperty,

@francescalb
Copy link
Collaborator Author

In tests/ontopy_tests/test_patch.py:

new annotations for Atoms should be updated in the test:

    setassert(
        emmo.Atom.get_annotations(all=True).keys(),
        {
            "IEVReference",
            "ISO14040Reference",
            "ISO80000Reference",
            "ISO9000Reference",
            "OWLDLRestrictedAxiom",
            "VIMTerm",
            "abstract",
            "altLabel",
            "comment",
            "conceptualisation",
            "contact",
            "contributor",
            "creator",
            "dbpediaReference",
            "definition",
            "elucidation",
            "etymology",
            "example",
            "figure",
            "iupacReference",
            "license",
            "logo",
            "minQualifiedCardinality",
            "omReference",
            "prefLabel",
            "publisher",
            "qualifiedCardinality",
            "qudtReference",
            "title",
            "ucumCode",
            "uneceCommonCode",
            "unitSymbol",
            "wikidataReference",
            "wikipediaReference",
        },
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant