We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I was just having a quick look through the code and noticed that set.seed() is used within a function (https://github.com/emlab-ucsb/oceandatr/blob/main/R/get_enviro_regions.R#L103-L107). This isn't considered best practice in R pacakge development and will cause issues for CRAN submission (see https://stackoverflow.com/questions/70624290/r-package-submission-error-concerning-set-seed). If you think it's really important to have a seed parameter for the function, I'd suggest using withr::with_seed() so the seed is only modified temporarily (https://withr.r-lib.org/reference/with_seed.html). How does that sound?
set.seed()
withr::with_seed()
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I was just having a quick look through the code and noticed that
set.seed()is used within a function (https://github.com/emlab-ucsb/oceandatr/blob/main/R/get_enviro_regions.R#L103-L107). This isn't considered best practice in R pacakge development and will cause issues for CRAN submission (see https://stackoverflow.com/questions/70624290/r-package-submission-error-concerning-set-seed). If you think it's really important to have a seed parameter for the function, I'd suggest usingwithr::with_seed()so the seed is only modified temporarily (https://withr.r-lib.org/reference/with_seed.html). How does that sound?The text was updated successfully, but these errors were encountered: