-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geomorphology doesn't seem to work for gridded data #41
Comments
Thanks Jase. I don't get an error. I think it might be due to recent updates to |
No that doesn't seem to be the problem on my end. Still getting the same error. But note, it doesn't look like you increasing the version of I'll try and do some more debugging tomorrow. Gotta prepare for a meeting now |
I re-installed both packages from Github and still don't get any errors. Any extra info you can give would be great. Noted about the dependencies and versioning. I'll add the R>=3.5 dependency to both. Using So you shouldn't have to use |
Fair call about the |
Both
|
Yep definitely fail for
That being said, when I try
I get an error because |
I'll test the 2nd error you highlight. sf should be able to deal with that. But the first one (my example I sent) shouldn't error I don't think. It should return the PUs with 0's in each row. Imagine you have global seamount data with a small planning area and there are no seamounts within the planning area. It shouldn't error but return 0's. Perhaps I should be creating that exact scenario, but I didn't have a chance to. Basically if there is no coverage it should return no coverage, not an error. Does that make sense? |
Yeah, so that's an interesting point. I actually changed the package to return error when there is no data in the area (area polygon or spatial grid). My thinking was that the user should be made aware of this: if they just get an empty grid/ polygon, surely you'd be thinking "where's my data"? I'd be interested to get your thoughts though. |
I think you should return a warning or display a message, but then return the PUs with 0s. It stuffs up my pipes or scripts if it errors. For example in shinyplanr, I throw all the data at it, but it doesn't mean there will be data in all PUs. It's the same if the data doesn't meet the cutoff. It returns a 0, not an error. How would it work with your get_features() script didn't have a seamount, but had a pelagic regionalisation. It would error I assume, despite the fact some data exists. Happy to chat in more detail after the meeting tomorrow if you want. |
Running the Bermuda example in the help fails
Created on 2024-04-02 with reprex v2.1.0
The text was updated successfully, but these errors were encountered: