New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grad_norm (line 32) should be before optimizer.step() (line 35) #3

Open

maximilianigl opened this issue Apr 18, 2018 · 1 comment

maximilianigl commented Apr 18, 2018

Or am I wrong?

Owner

emited commented May 24, 2018 •

edited

Loading

You are right again ! Don't hesitate if you want to send in a PR to correct this.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment