-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about implementing Unity (Game Engine) #561
Comments
Happy to hear that you're planning to do this!
One of my goals with this repo (alongside helping people learn to do refactoring properly) is to point out the advantages of approval testing for legacy code. If Unity doesn't have an explicit test framework for this style of testing yet then I don't want you to try to invent one just for this kata. |
Thanks for the reply! Unity does have a custom version of NUnit for C# that it uses, as well as a graphical interface for running the tests from the Unity editor. It's actually used by a lot fewer beginners than I would hope, which is most of my motivation for building Unity language support in this repo. I'll try to be very informative in my readme on how to setup and run these tests. |
Hi @emilybache, I'm working on adapting the kata for Unity game developers. Here's some questions I have:
Unity doesn't have a way to compile down to a command line program, so I'm not sure I'll be able to integrate it with TextTest. Would it be suitable/appropriate to write some code to compare a custom log with the text file instead? Or does this make Unity a bad candidate for addition into this repo?
As I was reviewing the C# ApprovalTest.ThirtyDays.verified.txt file, I noticed that I hadn't implemented the conjured item feature yet, but my output was identical. The existing file seems to have output that doesn't include the conjured item feature (ex: day 1 mana cake quality = 6, and day 2 it's 5 instead of 4). Is this a mistake or am I missing something?
Do you have any other concerns or words of advice as I try to implement a Unity version of this kata?
Let me know, thanks!
The text was updated successfully, but these errors were encountered: