-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling com.microsoft.playready DRM scheme #389
Comments
What would be needed to add support? What platforms are supported? We will merge acceptable pull requests that would add this. |
Not sure at this moment. I bumped into it while I was comparing:
This tells something, though: https://github.com/peak3d/inputstream.adaptive/wiki#supported-drm
Browsing through inputstream.adaptive it seems that playready implementation is in place and not so special, so I guess passing any valid DRM scheme from inputstreamhelper to inputstream.adaptive would do. https://github.com/peak3d/inputstream.adaptive/search?q=playready&type=Code On the other hand, passing script.module.inputstreamhelper/lib/inputstreamhelper/__init__.py Lines 57 to 61 in b0120b4
so (at least) having additional entry could be enough. |
I doubt there is anything inputstreamhelper can help with (on Android) and therefore should not be a dependency when playing PlayReady-protected streams. Unless there is any proof to the contrary. What probably could help this effort is demo PlayReady streams that people can test (on Android): |
I think ideally ISH should support the same DRM schemes as IS.A. AFAIK in some cases streams are protected with PlayReady in higher resolutions, but use Widevine for lower ones. So it might help if ISH could check for PlayReady support. Then an addon could do something like this: if Helper(drm='com.microsoft.playready').check_inputstream():
# play with playready
elif Helper(drm='com.widevine.alpha').check_inputstream():
# play with widevine
else:
... Any ideas how to check for PlayReady support? Best would be if it wasn't necessary to try and play a test file. |
@horstle We can add it, but it would only use PlayReady on Android currently, and it would be up to the add-on to have an option to select which DRM-selection mechanism to use if both are supported. And ISH would not be doing anything with it, except maybe return if not Android. Personally, I would wait until there is an actual need for this from an add-on, and this could be tested. |
i am using an Android fire tv 4k trying to run the NBA plugin and on live games i have no sound but i do in archived games. |
Thanks @scottydulton! The audio issue should not be related to ISH, I wanted to focus on @dagwieers @horstle As you can see here https://github.com/ivankokan/xbmc.plugin.video.nba/blob/master/src/common.py, we are explicitly using
We would like to test script.module.inputstreamhelper/lib/inputstreamhelper/__init__.py Lines 57 to 61 in b0120b4
If you need more information, please let us know. |
I think if you just add |
was this added in Kodi Nexus? |
There were no changes so far in inputstremhelper concerning playready. |
I see that inputstream.adaptive supports
com.microsoft.playready
along withcom.widevine.alpha
(https://github.com/peak3d/inputstream.adaptive/wiki/Integration#inputstreamadaptivelicense_type).Will it be handled within Helper, e.g. https://github.com/emilsvennesson/script.module.inputstreamhelper/blob/master/lib/inputstreamhelper/config.py#L14-L17?
The text was updated successfully, but these errors were encountered: