Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML syntax error in log.tmLanguage #432

Open
sebthom opened this issue Oct 19, 2022 · 3 comments
Open

XML syntax error in log.tmLanguage #432

sebthom opened this issue Oct 19, 2022 · 3 comments

Comments

@sebthom
Copy link

sebthom commented Oct 19, 2022

The file https://github.com/emilast/vscode-logfile-highlighter/blob/master/syntaxes/log.tmLanguage is not well formed in lines 42, 69, 96, 123, 150, 168, 239, 279, This prevents it from being read by an XML parser. It contains an unescaped a left angle bracket (<):

<string>(?<=^[\s\d\p]*)\bV\b</string>

Possible solutions are:

<string>(?&lt;=^[\s\d\p]*)\bV\b</string>

or using CDATA:

<string><![CDATA[(?<=^[\s\d\p]*)\bV\b]]></string>
@ssbarnea

This comment was marked as outdated.

@sebthom
Copy link
Author

sebthom commented Nov 25, 2022

@ssbarnea I don't understand your comment. my issue says nothing about parsing XML with regex. I am saying the tmLanguage file - which is an XML file - is not well formed, i. e. does not have characters escaped as required by the XML spec.

@ssbarnea
Copy link

Oops, sorry I got the wrong impression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants