-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic benchmarking structure #413
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the first approve :) Thank you very much for all of the work and for including all of the comments :)
Only thing I'd like to see removed is the plotting, but I'll leave that up to you and @AdrianSosic whether or not that should be in here.
b3a151b
to
bae86d1
Compare
… and simplify callable execution
…unctionDefinition for clarity and update references accordingly
Co-authored-by: Martin Fitzner <[email protected]>
46301ba
to
27893fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the PR description and we are ready to go 🚀
As agreed, a follow-up PR will take care of refactoring the class responsibilities but as a first version, this will fulfill its purpose 👍🏼
dff35ba
to
d902170
Compare
Since #410 added too many lines, lets start over with a single basic structure, which includes:
After this PR is reviewed, I plan to create follow up PRs which may run in parallel:
Please feel free to adjust or extend this list as necessary. I appreciate your feedback.