Remove optional telemetry group #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
added
bug
Scienfitz
reviewed
Mar 25, 2024
Scienfitz
approved these changes
Mar 26, 2024
AdrianSosic
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Hi @AVHopp, great, thanks for the PR 🏆 Only one thing to change, see below
|
Fixes #179 |
Scienfitz
approved these changes
Mar 26, 2024
AVHopp
force-pushed
the
repo/remove_telemetry_group
branch
from
b161364 to
ae6ed27
Compare
AdrianSosic
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the optional
telemetrygroup frompyproject.toml. The corresponding packages are now directly included without having them as a separate group.This was necessary since there were problems with installing
baybeviapoetrysince thedependenciescontained this explicit dependency. To enable installation with poetry, this was thus changed.