Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer gRPC libraries #115

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Support newer gRPC libraries #115

merged 1 commit into from
Dec 5, 2024

Conversation

krousey
Copy link
Contributor

@krousey krousey commented Nov 25, 2024

Google's gRPC libraries have removed the Data field from the payload structs in the stats package. This change updates the larking library to support the newer gRPC libraries.

Closes #114

@emcfarlane
Copy link
Owner

@krousey thanks for the update! Mind merging in main to get tests running?

Google's gRPC libraries have removed the Data field from the payload
structs in the stats package. This change updates the larking library to
support the newer gRPC libraries.
@krousey
Copy link
Contributor Author

krousey commented Dec 5, 2024

I rebased on top of your CI fixes. Thanks for looking at this.

Copy link
Owner

@emcfarlane emcfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emcfarlane emcfarlane merged commit 191f5a2 into emcfarlane:main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google.golang.org/grpc/stats removed Data fields
2 participants