Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No retry after failure #465

Open
kralikba opened this issue Oct 1, 2024 · 0 comments
Open

No retry after failure #465

kralikba opened this issue Oct 1, 2024 · 0 comments

Comments

@kralikba
Copy link

kralikba commented Oct 1, 2024

Hi,

I have occasionally encountered a situation where Reflector failed with an unexpected Kubernetes API Server error regarding creating a secret, but even after the reason has been cleared, the secret was still not created.

I think the cause is that if ResourceMirror.ResourceReflect fails, it catches the exception, logs it, then returns successfully:

Logger.LogError(ex, "Could not reflect {sourceId} to {targetId} due to exception.", sourceId, targetId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant