Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code samples need updating for best practice #1895

Open
MelSumner opened this issue Jan 23, 2023 · 0 comments
Open

Some code samples need updating for best practice #1895

MelSumner opened this issue Jan 23, 2023 · 0 comments

Comments

@MelSumner
Copy link
Member

MelSumner commented Jan 23, 2023

Reading through https://guides.emberjs.com/release/components/template-lifecycle-dom-and-modifiers/

There are some code samples that could use an update, as they are out-of-date for best practices.

Specifically, the examples showing an article element containing a header and an h1.

These days, it's really best to have one header and one h1 per page. It would be fine to change these to divs with demonstrative classes on them, e.g.,

<article>
  <div class="article__title">{{@title}}</div>
  <div class="article__content">{{@body}}</div>
</article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant