Add the script tag after-render #48
Conversation
There was a problem hiding this comment.
I wouldn't say it is "kinda strange", it is just the simple approach. The current approach doesn't cause any abnormal behavior, but it is likely non-optimal.
Should we do the same thing for CSS loader? It likely isn't as big of a deal as loading JS mid-run-loop, but seems like it may still be beneficial.
| document.head.appendChild(script); | ||
| document.head.appendChild(script); | ||
| } catch(e) { | ||
| reject(e); |
There was a problem hiding this comment.
What error would we expect to happen here?
There was a problem hiding this comment.
none, this is to handle the exceptional cases.
There was a problem hiding this comment.
This also maintains existing behavior. Currently if any of those lines error, the promise constructor will catch them. As this PR moves them to be async, we must manage that ourselves.
addon/loaders/js.js
Outdated
| @@ -15,11 +15,17 @@ export default nodeLoader(function js(uri) { | |||
| return resolve(); | |||
| } | |||
|
|
|||
| const script = createLoadElement('script', resolve, reject); | |||
| Ember.run.schedule('afterRender', () => { | |||
There was a problem hiding this comment.
We should add a comment as to why this afterRender is present.
We cannot simply return the promise in the failure scenarios (since returning a rejected promise will fail the test). I have added back a small assertion confirming the rejections in cases we _know_ should reject. The CSS load failure scenario is a bit annoying/odd because we cannot guarantee that we fail properly when the asset cannot be loaded (due to lack of browser support for `onload`/`onerror` callbacks with the `<link>` element).
rwjblue
force-pushed
the
add-new-code-after-render
branch
from
9a84986
to
96f90e8
Compare
|
Rebased this on top of latest master, and fixed the two failing assertions (both around @stefanpenner / @trentmwillis - This is ready for another look. |
| @@ -19,34 +20,46 @@ export default nodeLoader(function css(uri) { | |||
| return resolve(); | |||
| } | |||
|
|
|||
| // Try using the default onload/onerror handlers... | |||
| const link = createLoadElement('link', resolve, reject); | |||
There was a problem hiding this comment.
Why move this declaration outside the block where it is initialized?
|
@stefanpenner - Mind rebasing? |
|
@stefanpenner mind rebasing? please |
|
sure |
|
@stefanpenner I'd love to see this merge, you want some help? |
|
@villander yes please |
|
@stefanpenner conflicts solved by #81 |
Kinda strange to add to the DOM during just any period, we likely want this to always happen when stuff has settled down.
In-theory this could be made pluggable, allowing an application to provide an alternative schedular.
cc @scalvert